Bug 2033752

Summary: make verify fails due to missing yaml-patch
Product: OpenShift Container Platform Reporter: dagray
Component: Node Tuning OperatorAssignee: Jiří Mencák <jmencak>
Status: CLOSED ERRATA QA Contact: liqcui
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.9CC: aos-bugs, dagray
Target Milestone: ---   
Target Release: 4.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 2033755 (view as bug list) Environment:
Last Closed: 2022-03-10 16:34:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2033755    

Description dagray 2021-12-17 19:00:15 UTC
Description of problem:
make verify CI test fails on 4.9 and 4.10 due to missing yaml-patch download. 

Steps to Reproduce:
1. Clone the cluster-node-tuning-operator source code
2. Run `make verify`

Actual results:
Output: 

verify-gofmt: OK
Installing yq into '_output/tools/bin/yq-2.4.0'
mkdir -p '_output/tools/bin/'
curl -s -f -L https://github.com/mikefarah/yq/releases/download/2.4.0/yq_linux_amd64 -o '_output/tools/bin/yq-2.4.0'
chmod +x '_output/tools/bin/yq-2.4.0';
Installing yaml-patch into '_output/tools/bin/yaml-patch-v0.0.10'
mkdir -p '_output/tools/bin/'
curl -s -f -L https://github.com/krishicks/yaml-patch/releases/download/v0.0.10/yaml_patch_linux -o '_output/tools/bin/yaml-patch-v0.0.10'
make: *** [ensure-yaml-patch] Error 22

Expected results:
make verify should run successfully

Additional info:

Can be fixed by updating build-machinery-go to  v0.0.0-20211213093930-7e33a7eb4ce3

Comment 1 liqcui 2021-12-20 08:53:21 UTC
git clone https://github.com/openshift/cluster-node-tuning-operator
Cloning into 'cluster-node-tuning-operator'...
remote: Enumerating objects: 28760, done.
remote: Counting objects: 100% (5147/5147), done.
remote: Compressing objects: 100% (2523/2523), done.
remote: Total 28760 (delta 2628), reused 4402 (delta 2404), pack-reused 23613
Receiving objects: 100% (28760/28760), 32.23 MiB | 27.14 MiB/s, done.
Resolving deltas: 100% (13395/13395), done.
[ocpadmin@ec2-18-217-45-133 nto]$ cd cluster-node-tuning-operator
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ git checkout release-4.10
Branch 'release-4.10' set up to track remote branch 'release-4.10' from 'origin'.
Switched to a new branch 'release-4.10'
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ make verify
Installing controller-gen into '_output/tools/bin/controller-gen-v0.6.0'
mkdir -p '_output/tools/bin/'
curl -s -f -L https://github.com/openshift/kubernetes-sigs-controller-tools/releases/download/v0.6.0/controller-gen-linux-amd64 -o '_output/tools/bin/controller-gen-v0.6.0'
chmod +x '_output/tools/bin/controller-gen-v0.6.0';
Installing yq into '_output/tools/bin/yq-2.4.0'
mkdir -p '_output/tools/bin/'
curl -s -f -L https://github.com/mikefarah/yq/releases/download/2.4.0/yq_linux_amd64 -o '_output/tools/bin/yq-2.4.0'
chmod +x '_output/tools/bin/yq-2.4.0';
Installing yaml-patch into '_output/tools/bin/yaml-patch-v0.0.11'
mkdir -p '_output/tools/bin/'
curl -s -f -L https://github.com/pivotal-cf/yaml-patch/releases/download/v0.0.11/yaml_patch_linux -o '_output/tools/bin/yaml-patch-v0.0.11'
chmod +x '_output/tools/bin/yaml-patch-v0.0.11';
'_output/tools/bin/controller-gen-v0.6.0' schemapatch:manifests="./manifests" paths="./pkg/apis/tuned/v1" output:dir="/tmp/tmp.pGGMdD1KVo"
_output/tools/bin/yaml-patch-v0.0.11 -o './manifests/20-tuned.crd.yaml-patch' < '/tmp/tmp.pGGMdD1KVo/20-tuned.crd.yaml' > '/tmp/tmp.pGGMdD1KVo/20-tuned.crd.yaml.patched'
mv '/tmp/tmp.pGGMdD1KVo/20-tuned.crd.yaml.patched' '/tmp/tmp.pGGMdD1KVo/20-tuned.crd.yaml'
diff -Naup './manifests/20-profile.crd.yaml' '/tmp/tmp.pGGMdD1KVo/20-profile.crd.yaml'
diff -Naup './manifests/20-tuned.crd.yaml' '/tmp/tmp.pGGMdD1KVo/20-tuned.crd.yaml'
cp -R ./manifests/* /tmp/tmp.OdnbOH8i5l/
( echo '# *** AUTOMATICALLY GENERATED FILE - DO NOT EDIT ***'; _output/tools/bin/yaml-patch-v0.0.11 -o './profile-patches/ibm-cloud-managed/50-operator.yaml-patch' < '/tmp/tmp.OdnbOH8i5l/50-operator.yaml' ) > '/tmp/tmp.OdnbOH8i5l/50-operator-ibm-cloud-managed.yaml'
diff -Naup ./manifests /tmp/tmp.OdnbOH8i5l
verify-gofmt: OK
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ mkdir -p '_output/tools/bin/'
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ curl -s -f -L https://github.com/mikefarah/yq/releases/download/2.4.0/yq_linux_amd64 -o '_output/tools/bin/yq-2.4.0'
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ chmod +x '_output/tools/bin/yq-2.4.0';
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ mkdir -p '_output/tools/bin/'
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ curl -s -f -L https://github.com/krishicks/yaml-patch/releases/download/v0.0.10/yaml_patch_linux -o '_output/tools/bin/yaml-patch-v0.0.10'
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ make verify
Using existing controller-gen from "_output/tools/bin/controller-gen-v0.6.0"
Using existing yq from "_output/tools/bin/yq-2.4.0"
Using existing yaml-patch from "_output/tools/bin/yaml-patch-v0.0.11"
'_output/tools/bin/controller-gen-v0.6.0' schemapatch:manifests="./manifests" paths="./pkg/apis/tuned/v1" output:dir="/tmp/tmp.In72n5cUGG"
_output/tools/bin/yaml-patch-v0.0.11 -o './manifests/20-tuned.crd.yaml-patch' < '/tmp/tmp.In72n5cUGG/20-tuned.crd.yaml' > '/tmp/tmp.In72n5cUGG/20-tuned.crd.yaml.patched'
mv '/tmp/tmp.In72n5cUGG/20-tuned.crd.yaml.patched' '/tmp/tmp.In72n5cUGG/20-tuned.crd.yaml'
diff -Naup './manifests/20-profile.crd.yaml' '/tmp/tmp.In72n5cUGG/20-profile.crd.yaml'
diff -Naup './manifests/20-tuned.crd.yaml' '/tmp/tmp.In72n5cUGG/20-tuned.crd.yaml'
cp -R ./manifests/* /tmp/tmp.JCqyztFqgo/
( echo '# *** AUTOMATICALLY GENERATED FILE - DO NOT EDIT ***'; _output/tools/bin/yaml-patch-v0.0.11 -o './profile-patches/ibm-cloud-managed/50-operator.yaml-patch' < '/tmp/tmp.JCqyztFqgo/50-operator.yaml' ) > '/tmp/tmp.JCqyztFqgo/50-operator-ibm-cloud-managed.yaml'
diff -Naup ./manifests /tmp/tmp.JCqyztFqgo
verify-gofmt: OK

Comment 4 errata-xmlrpc 2022-03-10 16:34:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056