Bug 2033755 - make verify fails due to missing yaml-patch
Summary: make verify fails due to missing yaml-patch
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Node Tuning Operator
Version: 4.9
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.9.z
Assignee: Jiří Mencák
QA Contact: liqcui
URL:
Whiteboard:
Depends On: 2033752
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-17 19:06 UTC by dagray
Modified: 2022-01-10 08:51 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of: 2033752
Environment:
Last Closed: 2022-01-10 08:50:46 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-node-tuning-operator pull 306 0 None open [release-4.9] Bug 2033755: build-machinery-go: bump to the latest version 2021-12-20 08:57:03 UTC
Red Hat Product Errata RHBA-2022:0029 0 None None None 2022-01-10 08:51:15 UTC

Description dagray 2021-12-17 19:06:33 UTC
+++ This bug was initially created as a clone of Bug #2033752 +++

Description of problem:
make verify CI test fails on 4.9 and 4.10 due to missing yaml-patch download. 

Steps to Reproduce:
1. Clone the cluster-node-tuning-operator source code
2. Run `make verify`

Actual results:
Output: 

verify-gofmt: OK
Installing yq into '_output/tools/bin/yq-2.4.0'
mkdir -p '_output/tools/bin/'
curl -s -f -L https://github.com/mikefarah/yq/releases/download/2.4.0/yq_linux_amd64 -o '_output/tools/bin/yq-2.4.0'
chmod +x '_output/tools/bin/yq-2.4.0';
Installing yaml-patch into '_output/tools/bin/yaml-patch-v0.0.10'
mkdir -p '_output/tools/bin/'
curl -s -f -L https://github.com/krishicks/yaml-patch/releases/download/v0.0.10/yaml_patch_linux -o '_output/tools/bin/yaml-patch-v0.0.10'
make: *** [ensure-yaml-patch] Error 22

Expected results:
make verify should run successfully

Additional info:

Can be fixed by updating build-machinery-go to  v0.0.0-20211213093930-7e33a7eb4ce3

Comment 2 liqcui 2021-12-21 01:31:55 UTC
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ git checkout release-4.9
Already on 'release-4.9'
Your branch is up to date with 'origin/release-4.9'.
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ make verify
verify-gofmt: OK
Using existing yq from "_output/tools/bin/yq-2.4.0"
Using existing yaml-patch from "_output/tools/bin/yaml-patch-v0.0.11"
cp -R ./manifests/* /tmp/tmp.SaHOa3NqP1/
( echo '# *** AUTOMATICALLY GENERATED FILE - DO NOT EDIT ***'; _output/tools/bin/yaml-patch-v0.0.11 -o './profile-patches/ibm-cloud-managed/50-operator.yaml-patch' < '/tmp/tmp.SaHOa3NqP1/50-operator.yaml' ) > '/tmp/tmp.SaHOa3NqP1/50-operator-ibm-cloud-managed.yaml'
diff -Naup ./manifests /tmp/tmp.SaHOa3NqP1
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ mkdir -p '_output/tools/bin/'
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ curl -s -f -L https://github.com/mikefarah/yq/releases/download/2.4.0/yq_linux_amd64 -o '_output/tools/bin/yq-2.4.0'
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ chmod +x '_output/tools/bin/yq-2.4.0';
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ mkdir -p '_output/tools/bin/'
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ curl -s -f -L https://github.com/krishicks/yaml-patch/releases/download/v0.0.10/yaml_patch_linux -o '_output/tools/bin/yaml-patch-v0.0.10'
[ocpadmin@ec2-18-217-45-133 cluster-node-tuning-operator]$ make verify
verify-gofmt: OK
Using existing yq from "_output/tools/bin/yq-2.4.0"
Using existing yaml-patch from "_output/tools/bin/yaml-patch-v0.0.11"
cp -R ./manifests/* /tmp/tmp.0AZmwyhSxp/
( echo '# *** AUTOMATICALLY GENERATED FILE - DO NOT EDIT ***'; _output/tools/bin/yaml-patch-v0.0.11 -o './profile-patches/ibm-cloud-managed/50-operator.yaml-patch' < '/tmp/tmp.0AZmwyhSxp/50-operator.yaml' ) > '/tmp/tmp.0AZmwyhSxp/50-operator-ibm-cloud-managed.yaml'
diff -Naup ./manifests /tmp/tmp.0AZmwyhSxp

Comment 5 errata-xmlrpc 2022-01-10 08:50:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.9.13 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:0029


Note You need to log in before you can comment on or make changes to this bug.