Bug 2033816

Summary:	Review Request: monkeytype - Generating Python type annotations from sampled production types
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mhroncok, ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-12-10 16:54:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michel Lind 2021-12-17 22:50:11 UTC

Spec URL: https://salimma.fedorapeople.org/specs/meta/python-monkeytype.spec
SRPM URL: https://salimma.fedorapeople.org/specs/meta/python-monkeytype-21.5.0-1.fc35.src.rpm
Description: 
MonkeyType collects runtime types of function arguments and return values, and
can automatically generate stub files or even add draft type annotations
directly to your Python code based on the types collected at runtime.

Fedora Account System Username: salimma

Comment 1 Miro Hrončok 2021-12-20 13:09:52 UTC

> Provides:       python%{python3_pkgversion}-%{modname} = %{version}-%{release}

Use this instead:

  %py_provides python%{python3_pkgversion}-%{modname}

See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_for_importable_modules


Also, I'd suggest keeping the component name just "monkeytype", if that is the built package name.

Comment 2 Michel Lind 2021-12-21 19:45:04 UTC

Spec URL: https://salimma.fedorapeople.org/specs/meta/monkeytype.spec
SRPM URL: https://salimma.fedorapeople.org/specs/meta/monkeytype-21.5.0-1.fc35.src.rpm

Thanks Miro!

Comment 3 Neal Gompa 2021-12-21 19:52:27 UTC

Review notes:

[x]: Package follows Fedora Python Packaging Guidelines
[x]: Package builds and installs
[x]: No serious issues from rpmlint
[x]: License is correctly identified and installed

PACKAGE APPROVED.

Comment 4 Michel Lind 2021-12-21 20:01:12 UTC

Thanks!

❯ fedpkg request-repo monkeytype 2033816              
https://pagure.io/releng/fedora-scm-requests/issue/39988

Comment 5 Gwyn Ciesla 2021-12-21 20:45:35 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/monkeytype

Comment 6 Package Review 2022-12-10 16:54:08 UTC

Package is now in repositories, closing review.