Spec URL: https://salimma.fedorapeople.org/specs/meta/python-monkeytype.spec SRPM URL: https://salimma.fedorapeople.org/specs/meta/python-monkeytype-21.5.0-1.fc35.src.rpm Description: MonkeyType collects runtime types of function arguments and return values, and can automatically generate stub files or even add draft type annotations directly to your Python code based on the types collected at runtime. Fedora Account System Username: salimma
> Provides: python%{python3_pkgversion}-%{modname} = %{version}-%{release} Use this instead: %py_provides python%{python3_pkgversion}-%{modname} See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_for_importable_modules Also, I'd suggest keeping the component name just "monkeytype", if that is the built package name.
Spec URL: https://salimma.fedorapeople.org/specs/meta/monkeytype.spec SRPM URL: https://salimma.fedorapeople.org/specs/meta/monkeytype-21.5.0-1.fc35.src.rpm Thanks Miro!
Review notes: [x]: Package follows Fedora Python Packaging Guidelines [x]: Package builds and installs [x]: No serious issues from rpmlint [x]: License is correctly identified and installed PACKAGE APPROVED.
Thanks! ❯ fedpkg request-repo monkeytype 2033816 https://pagure.io/releng/fedora-scm-requests/issue/39988
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/monkeytype
Package is now in repositories, closing review.