Bug 2034224

Summary:	Review Request: rust-salsa20 - Salsa20 Stream Cipher
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Davide Cavalca <davide>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	davide, package-review
Target Milestone:	---	Flags:	davide: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-06 21:26:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2034225

Description Fabio Valentini 2021-12-20 12:37:59 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-salsa20.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-salsa20-0.8.1-1.fc35.src.rpm

Description:
Salsa20 Stream Cipher.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-12-20 12:38:02 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=80228639

Comment 2 Fabio Valentini 2021-12-20 12:38:54 UTC

Note: Not packaging the latest version is intentional.
The reason I am packaging this crate is that version 0.8.1 of this crate appears in the dependency tree of rust-rsa 0.5.0, which I am working on updating.
I will update the crate once that is possible.

Comment 3 Davide Cavalca 2022-01-05 09:38:20 UTC

Taking this review

Comment 4 Davide Cavalca 2022-01-05 09:39:45 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- crate version isn't the latest, but justification is provided
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 5 Fabio Valentini 2022-01-05 22:53:25 UTC

Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/40522
https://pagure.io/releng/fedora-scm-requests/issue/40523
https://pagure.io/releng/fedora-scm-requests/issue/40524

Comment 6 Gwyn Ciesla 2022-01-06 14:32:14 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-salsa20

Comment 7 Fabio Valentini 2022-01-06 21:26:53 UTC

Package was built for all current Fedora branches:
https://bodhi.fedoraproject.org/updates/FEDORA-2022-eeb222eb42
https://bodhi.fedoraproject.org/updates/FEDORA-2022-cd1f55e294
https://bodhi.fedoraproject.org/updates/FEDORA-2022-f5390ea463