Bug 2034224 - Review Request: rust-salsa20 - Salsa20 Stream Cipher
Summary: Review Request: rust-salsa20 - Salsa20 Stream Cipher
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2034225
TreeView+ depends on / blocked
 
Reported: 2021-12-20 12:37 UTC by Fabio Valentini
Modified: 2022-01-06 21:26 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-01-06 21:26:53 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2021-12-20 12:37:59 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-salsa20.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-salsa20-0.8.1-1.fc35.src.rpm

Description:
Salsa20 Stream Cipher.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-12-20 12:38:02 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=80228639

Comment 2 Fabio Valentini 2021-12-20 12:38:54 UTC
Note: Not packaging the latest version is intentional.
The reason I am packaging this crate is that version 0.8.1 of this crate appears in the dependency tree of rust-rsa 0.5.0, which I am working on updating.
I will update the crate once that is possible.

Comment 3 Davide Cavalca 2022-01-05 09:38:20 UTC
Taking this review

Comment 4 Davide Cavalca 2022-01-05 09:39:45 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- crate version isn't the latest, but justification is provided
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 6 Gwyn Ciesla 2022-01-06 14:32:14 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-salsa20


Note You need to log in before you can comment on or make changes to this bug.