Bug 2035958

Summary: Review Request: libchipcard - A library for easy access to smart cards (chipcards)
Product: [Fedora] Fedora Reporter: Gwyn Ciesla <gwync>
Component: Package ReviewAssignee: Benson Muite <benson_muite>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: alciregi, benson_muite, package-review, tech
Target Milestone: ---Flags: benson_muite: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-11-10 22:14:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2003480    

Description Gwyn Ciesla 2021-12-28 20:59:36 UTC 
SRPM: https://fedorapeople.org/~limb/review/libchipcard/libchipcard-5.1.6-1.fc35.src.rpm
SPEC: https://fedorapeople.org/~limb/review/libchipcard/libchipcard.spec

Description:
Libchipcard allows easy access to smart cards. It provides basic access
to memory and processor cards and has special support for German medical
cards, German "GeldKarte" and HBCI (homebanking) cards (both type 0 and
type 1).
It accesses the readers via CTAPI or IFD interfaces and has successfully
been tested with Towitoko, Kobil, SCM, Orga, Omnikey and Reiner-SCT readers.
Comment 1 ingli 2021-12-28 22:59:01 UTC 
as noted at https://bodhi.fedoraproject.org/updates/FEDORA-2021-1b812725a9, a locally built libchipcard works well together with the updated versions of aqbanking and gwenhywfar (and gnucash).
Comment 2 ingli 2022-05-17 23:55:08 UTC 
And, just to note: the spec's files requirements are well identified: 
BuildRequires: gcc-c++
BuildRequires: gwenhywfar-devel
BuildRequires: libsysfs-devel
BuildRequires: pcsc-lite-devel
BuildRequires: zlib-devel

configure, make, make install: works wonderfully with libchipcard-5.99.1beta
Comment 3 Benson Muite 2022-08-26 11:54:40 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[?]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[?]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Lesser General Public License,
     Version 2.1 [obsolete FSF postal address (Temple Place)]", "FSF All
     Permissive License", "[generated file]", "FSF Unlimited License (with
     License Retention) GNU General Public License v2.0 or later [generated
     file]", "GNU General Public License v2.0 or later [generated file]",
     "GNU General Public License v3.0 or later", "FSF Unlimited License
     [generated file]", "X11 License [generated file]", "*No copyright* GNU
     Lesser General Public License", "GNU General Public License v2.0 or
     later", "FSF Unlimited License (with License Retention) GNU General
     Public License, Version 2", "FSF Unlimited License (with License
     Retention)", "GNU Lesser General Public License v2.1 or later
     [obsolete FSF postal address (Temple Place)]", "*No copyright*
     [generated file]", "GNU General Public License v2.0 or later [obsolete
     FSF postal address (Temple Place)]", "GNU General Public License". 232
     files have unknown license. Detailed output of licensecheck in
     /home/FedoraPackaging/libchipcard/2035958-libchipcard/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/lib64/gwenhywfar/plugins/79(gwenhywfar),
     /usr/lib64/gwenhywfar/plugins/79/ct(gwenhywfar)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[?]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 143360 bytes in 20 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Unversioned so-files
--------------------
libchipcard: /usr/lib64/gwenhywfar/plugins/79/ct/chiptanusb.so
libchipcard: /usr/lib64/gwenhywfar/plugins/79/ct/ddvcard.so
libchipcard: /usr/lib64/gwenhywfar/plugins/79/ct/starcoscard.so
libchipcard: /usr/lib64/gwenhywfar/plugins/79/ct/zkacard.so

Source checksums
----------------
https://www.aquamaniac.de/rdm/attachments/download/382/libchipcard-5.1.6.tar.gz 
:
  CHECKSUM(SHA256) this package     : 6c07f527417f7562074f99012da4d11eb4dbafd33f49e66b442ccd6e3b8cfd20
  CHECKSUM(SHA256) upstream package : 6c07f527417f7562074f99012da4d11eb4dbafd33f49e66b442ccd6e3b8cfd20


Requires
--------
libchipcard (rpmlib, GLIBC filtered):
    /usr/bin/sh
    libc.so.6()(64bit)
    libchipcard.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgwenhywfar.so.79()(64bit)
    libpcsclite.so.1()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)

libchipcard-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    gwenhywfar-devel
    libchipcard(x86-64)
    libchipcard.so.6()(64bit)

libchipcard-debuginfo (rpmlib, GLIBC filtered):

libchipcard-debugsource (rpmlib, GLIBC filtered):



Provides
--------
libchipcard:
    libchipcard
    libchipcard(x86-64)
    libchipcard.so.6()(64bit)

libchipcard-devel:
    libchipcard-devel
    libchipcard-devel(x86-64)
    pkgconfig(libchipcard-client)
    pkgconfig(libchipcard-server)

libchipcard-debuginfo:
    debuginfo(build-id)
    libchipcard-debuginfo
    libchipcard-debuginfo(x86-64)
    libchipcard.so.6.1.6-5.1.6-1.fc38.x86_64.debug()(64bit)

libchipcard-debugsource:
    libchipcard-debugsource
    libchipcard-debugsource(x86-64)



Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review -b 2035958
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, C/C++
Disabled plugins: fonts, Ocaml, Python, Haskell, R, Perl, PHP, Java, SugarActivi
ty
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

$ rpmlint libchipcard-5.1.6-1.fc38.src.rpm
======================================== rpmlint session starts ========================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

libchipcard.src: W: summary-ended-with-dot A library for easy access to smart cards (chipcards).
libchipcard.spec:40: W: macro-in-comment %{_libdir}
libchipcard.spec:41: W: macro-in-comment %{_lib}
libchipcard.spec:41: W: macro-in-comment %{_libdir}
libchipcard.spec:42: W: macro-in-comment %endif
========= 1 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken 1.2 s =========

$ rpmlint libchipcard-5.1.6-1.fc38.x86_64.rpm 
======================================== rpmlint session starts ========================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

libchipcard.x86_64: W: summary-ended-with-dot A library for easy access to smart cards (chipcards).
libchipcard.x86_64: E: shlib-policy-excessive-dependency libgcc_s.so.1
libchipcard.x86_64: E: shlib-policy-excessive-dependency libstdc++.so.6
libchipcard.x86_64: W: non-conffile-in-etc /etc/chipcard/chipcardc.conf.default
libchipcard.x86_64: W: non-conffile-in-etc /etc/chipcard/chipcardc.conf.example
libchipcard.x86_64: W: no-manual-page-for-binary cardcommander
libchipcard.x86_64: W: no-manual-page-for-binary chipcard-config
libchipcard.x86_64: W: no-manual-page-for-binary chipcard-tool
libchipcard.x86_64: W: no-manual-page-for-binary geldkarte
libchipcard.x86_64: W: no-manual-page-for-binary kvkcard
libchipcard.x86_64: W: no-manual-page-for-binary memcard
libchipcard.x86_64: W: no-manual-page-for-binary usbtan-test
libchipcard.x86_64: W: no-manual-page-for-binary zkacard-tool
libchipcard.x86_64: E: incorrect-fsf-address /usr/share/licenses/libchipcard/COPYING
libchipcard.x86_64: W: incoherent-version-in-changelog 5.1.2-1 ['5.1.6-1.fc38', '5.1.6-1']
libchipcard.x86_64: W: files-duplicate /etc/chipcard/chipcardc.conf.example /etc/chipcard/chipcardc.conf.default
libchipcard.x86_64: W: files-duplicate /usr/share/chipcard/cards/cyberjack_pcsc/processorcard.xml /usr/share/chipcard/cards/cyberjack_pcsc/card.xml:/usr/share/chipcard/cards/cyberjack_pcsc/kvk.xml
libchipcard.x86_64: W: devel-file-in-non-devel-package /usr/bin/chipcard-config
======= 1 packages and 0 specfiles checked; 3 errors, 15 warnings, 3 badness; has taken 110.9 s ========

$ rpmlint libchipcard-devel-5.1.6-1.fc38.x86_64.rpm
======================================== rpmlint session starts ========================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

libchipcard-devel.x86_64: W: makefile-junk /usr/share/doc/libchipcard-devel/doc/Makefile.am
========= 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.4 s =========


Comments:
a) Signing key is available at https://www.aquamaniac.de/rdm/attachments/381/libchipcard-5.1.6.tar.gz.asc - this can be used to verify the source code
b) Some files are under GPL:
GNU General Public License
--------------------------
libchipcard-5.1.6/src/tools/kvkcard/main.c
libchipcard-5.1.6/src/tools/memcard/main.c

GNU General Public License v2.0 or later
----------------------------------------
libchipcard-5.1.6/ltmain.sh

GNU General Public License v2.0 or later [generated file]
---------------------------------------------------------
libchipcard-5.1.6/compile
libchipcard-5.1.6/depcomp
libchipcard-5.1.6/missing

GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]
-------------------------------------------------------------------------------------
libchipcard-5.1.6/src/tools/cardcommander/cardcommander.cpp

GNU General Public License v3.0 or later
----------------------------------------
libchipcard-5.1.6/config.guess
libchipcard-5.1.6/config.sub
Comment 4 ingli 2022-08-26 14:27:41 UTC 
Dear Benson,
thank you for running these tests/checks. Would you mind providing a high level summary for interested parties who cannot well interpret the tests? What is your conclusion from these tests?
Ta
Comment 5 Gwyn Ciesla 2022-08-26 14:41:10 UTC 
Updated:

SRPM: https://fedorapeople.org/~limb/review/libchipcard/libchipcard-5.1.6-2.fc36.src.rpm
SPEC: https://fedorapeople.org/~limb/review/libchipcard/libchipcard.spec

Commented out key verification as I can't find a valid keyring.
Comment 6 ingli 2022-08-26 15:29:48 UTC 
I am in touch with the developers elsewhere - should I ask them about a valid keyring for verification?
Comment 7 Gwyn Ciesla 2022-08-26 15:56:57 UTC 
Please! I downloaded the public key for the signature but it didn't work and I couldn't locate a keyring on the website.
Comment 8 ingli 2022-08-26 16:22:17 UTC 
ok, asked via
https://www.aquamaniac.de/rdm/issues/287
Comment 9 Benson Muite 2022-10-04 16:30:55 UTC 
It seems the keyring may take a while.  Can proceed without it.
Comment 10 Gwyn Ciesla 2022-10-04 16:32:57 UTC 
Indeed.
Comment 11 Benson Muite 2022-10-04 17:50:11 UTC 
Please update the source url:
https://www.aquamaniac.de/rdm/attachments/download/382/libchipcard-5.1.6.tar.gz

Possibly the signature can be removed:
https://www.aquamaniac.de/rdm/attachments/download/381/libchipcard-5.1.6.tar.gz.asc
Perhaps leave a comment in the spec file that the signing key is not known.
Comment 12 Gwyn Ciesla 2022-10-04 18:21:56 UTC 
SRPM: https://fedorapeople.org/~limb/review/libchipcard/libchipcard-5.1.6-3.fc37.src.rpm
SPEC: https://fedorapeople.org/~limb/review/libchipcard/libchipcard.spec

Done.
Comment 13 Benson Muite 2022-10-05 09:05:04 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[?]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Lesser General Public License,
     Version 2.1 [obsolete FSF postal address (Temple Place)]", "FSF All
     Permissive License", "[generated file]", "FSF Unlimited License (with
     License Retention) GNU General Public License v2.0 or later [generated
     file]", "GNU General Public License v2.0 or later [generated file]",
     "GNU General Public License v3.0 or later", "FSF Unlimited License
     [generated file]", "X11 License [generated file]", "*No copyright* GNU
     Lesser General Public License", "GNU General Public License v2.0 or
     later", "FSF Unlimited License (with License Retention) GNU General
     Public License, Version 2", "FSF Unlimited License (with License
     Retention)", "GNU Lesser General Public License v2.1 or later
     [obsolete FSF postal address (Temple Place)]", "*No copyright*
     [generated file]", "GNU General Public License v2.0 or later [obsolete
     FSF postal address (Temple Place)]", "GNU General Public License". 232
     files have unknown license. Detailed output of licensecheck in
     /home/FedoraPackaging/reviews/libchipcard/2035958-libchipcard/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/lib64/gwenhywfar/plugins/79(gwenhywfar),
     /usr/lib64/gwenhywfar/plugins/79/ct(gwenhywfar)
[c]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[?]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 143360 bytes in 20 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify occurs outside of %prep.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

libchipcard-debugsource.x86_64: E: zero-length /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/ct/chiptanusb/dummy.c
libchipcard-debugsource.x86_64: E: zero-length /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/ct/ddvcard/dummy.c
libchipcard-debugsource.x86_64: E: zero-length /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/ct/starcoscard/dummy.c
libchipcard-debugsource.x86_64: E: zero-length /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/ct/zkacard/dummy.c
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/libchipcard-5.1.6-3.fc38.x86_64
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/cardcommander-5.1.6-3.fc38.x86_64.debug
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/chipcard-tool-5.1.6-3.fc38.x86_64.debug
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/geldkarte-5.1.6-3.fc38.x86_64.debug
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/kvkcard-5.1.6-3.fc38.x86_64.debug
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/memcard-5.1.6-3.fc38.x86_64.debug
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/usbtan-test-5.1.6-3.fc38.x86_64.debug
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/zkacard-tool-5.1.6-3.fc38.x86_64.debug
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/gwenhywfar/plugins/79/ct/chiptanusb.so-5.1.6-3.fc38.x86_64.debug
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/gwenhywfar/plugins/79/ct/ddvcard.so-5.1.6-3.fc38.x86_64.debug
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/gwenhywfar/plugins/79/ct/starcoscard.so-5.1.6-3.fc38.x86_64.debug
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/gwenhywfar/plugins/79/ct/zkacard.so-5.1.6-3.fc38.x86_64.debug
libchipcard-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/libchipcard.so.6.1.6-5.1.6-3.fc38.x86_64.debug
libchipcard-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/libchipcard-5.1.6-3.fc38.x86_64
libchipcard.x86_64: E: shlib-policy-excessive-dependency libgcc_s.so.1
libchipcard.x86_64: E: shlib-policy-excessive-dependency libstdc++.so.6
libchipcard.x86_64: W: non-conffile-in-etc /etc/chipcard/chipcardc.conf.default
libchipcard.x86_64: W: non-conffile-in-etc /etc/chipcard/chipcardc.conf.example
libchipcard.x86_64: W: no-manual-page-for-binary cardcommander
libchipcard.x86_64: W: no-manual-page-for-binary chipcard-config
libchipcard.x86_64: W: no-manual-page-for-binary chipcard-tool
libchipcard.x86_64: W: no-manual-page-for-binary geldkarte
libchipcard.x86_64: W: no-manual-page-for-binary kvkcard
libchipcard.x86_64: W: no-manual-page-for-binary memcard
libchipcard.x86_64: W: no-manual-page-for-binary usbtan-test
libchipcard.x86_64: W: no-manual-page-for-binary zkacard-tool
libchipcard-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/libchipcard-5.1.6-3.fc38.x86_64
libchipcard-devel.x86_64: W: makefile-junk /usr/share/doc/libchipcard-devel/doc/Makefile.am
libchipcard-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/bin/cardcommander-5.1.6-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/bin/cardcommander-5.1.6-3.fc38.x86_64.debug'

libchipcard-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/bin/chipcard-tool-5.1.6-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/bin/chipcard-tool-5.1.6-3.fc38.x86_64.debug'

libchipcard-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/bin/geldkarte-5.1.6-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/bin/geldkarte-5.1.6-3.fc38.x86_64.debug'

libchipcard-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/bin/kvkcard-5.1.6-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/bin/kvkcard-5.1.6-3.fc38.x86_64.debug'

libchipcard-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/bin/memcard-5.1.6-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/bin/memcard-5.1.6-3.fc38.x86_64.debug'

libchipcard-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/bin/usbtan-test-5.1.6-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/bin/usbtan-test-5.1.6-3.fc38.x86_64.debug'

libchipcard-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/bin/zkacard-tool-5.1.6-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/bin/zkacard-tool-5.1.6-3.fc38.x86_64.debug'

libchipcard-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib64/gwenhywfar/plugins/79/ct/chiptanusb.so-5.1.6-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib64/gwenhywfar/plugins/79/ct/chiptanusb.so-5.1.6-3.fc38.x86_64.debug'

libchipcard-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib64/gwenhywfar/plugins/79/ct/ddvcard.so-5.1.6-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib64/gwenhywfar/plugins/79/ct/ddvcard.so-5.1.6-3.fc38.x86_64.debug'

libchipcard-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib64/gwenhywfar/plugins/79/ct/starcoscard.so-5.1.6-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib64/gwenhywfar/plugins/79/ct/starcoscard.so-5.1.6-3.fc38.x86_64.debug'

libchipcard-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib64/gwenhywfar/plugins/79/ct/zkacard.so-5.1.6-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib64/gwenhywfar/plugins/79/ct/zkacard.so-5.1.6-3.fc38.x86_64.debug'

libchipcard-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib64/libchipcard.so.6.1.6-5.1.6-3.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib64/libchipcard.so.6.1.6-5.1.6-3.fc38.x86_64.debug'

libchipcard.x86_64: E: incorrect-fsf-address /usr/share/licenses/libchipcard/COPYING
libchipcard-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz
libchipcard-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz
libchipcard.x86_64: W: files-duplicate /etc/chipcard/chipcardc.conf.example /etc/chipcard/chipcardc.conf.default
libchipcard.x86_64: W: files-duplicate /usr/share/chipcard/cards/cyberjack_pcsc/processorcard.xml /usr/share/chipcard/cards/cyberjack_pcsc/card.xml:/usr/share/chipcard/cards/cyberjack_pcsc/kvk.xml
libchipcard-debugsource.x86_64: W: files-duplicate /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/lib/client/base/card_imp.h /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/libchipcard5/chipcard/card_imp.h
libchipcard-debugsource.x86_64: W: files-duplicate /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/lib/client/cards/geldkarte/geldkarte_blog.h /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/libchipcard5/chipcard/cards/geldkarte_blog.h
libchipcard-debugsource.x86_64: W: files-duplicate /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/lib/client/cards/geldkarte/geldkarte_llog.h /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/libchipcard5/chipcard/cards/geldkarte_llog.h
libchipcard-debugsource.x86_64: W: files-duplicate /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/lib/client/cards/geldkarte/geldkarte_values.h /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/libchipcard5/chipcard/cards/geldkarte_values.h
libchipcard-debugsource.x86_64: W: files-duplicate /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/lib/client/cards/hiinsurancedata.h /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/libchipcard5/chipcard/cards/hiinsurancedata.h
libchipcard-debugsource.x86_64: W: files-duplicate /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/lib/client/cards/hipersonaldata.h /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/libchipcard5/chipcard/cards/hipersonaldata.h
libchipcard-debugsource.x86_64: W: files-duplicate /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/lib/client/cards/starcos/starcos_keydescr.h /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/libchipcard5/chipcard/cards/starcos_keydescr.h
libchipcard-debugsource.x86_64: W: files-duplicate /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/lib/client/base/client.h /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/libchipcard5/chipcard/client.h
libchipcard-debugsource.x86_64: W: files-duplicate /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/src/lib/sharedstuff/pininfo.h /usr/src/debug/libchipcard-5.1.6-3.fc38.x86_64/libchipcard5/chipcard/sharedstuff/pininfo.h
libchipcard.x86_64: W: devel-file-in-non-devel-package /usr/bin/chipcard-config
libchipcard-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/00/edfb4b9bd3560a65bcdfff8cbefac35ed74f11 ../../../.build-id/00/edfb4b9bd3560a65bcdfff8cbefac35ed74f11
libchipcard-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/1d/e77a8ab816eae7ae185286e012a669ba3e17ef ../../../.build-id/1d/e77a8ab816eae7ae185286e012a669ba3e17ef
libchipcard-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/1e/7a527ff1422aaaf61a4f323b112dea632889b0 ../../../.build-id/1e/7a527ff1422aaaf61a4f323b112dea632889b0
libchipcard-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/33/f51eef6f1100911948bb473928582d5a9c0737 ../../../.build-id/33/f51eef6f1100911948bb473928582d5a9c0737
libchipcard-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/44/bed6240c23b66dcaeb9013d16889c0f0d89841 ../../../.build-id/44/bed6240c23b66dcaeb9013d16889c0f0d89841
libchipcard-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/67/b916ecbef20df3d8862f5e2b2e06c08824b5f3 ../../../.build-id/67/b916ecbef20df3d8862f5e2b2e06c08824b5f3
libchipcard-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/79/4c1ba4c79df2a23d71c4e8e77cb3c402d9d25f ../../../.build-id/79/4c1ba4c79df2a23d71c4e8e77cb3c402d9d25f
libchipcard-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/88/7c37a8986f5315a713d57d26ea91ce25646e11 ../../../.build-id/88/7c37a8986f5315a713d57d26ea91ce25646e11
libchipcard-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/9e/e0c4128f01a1fcc36d67c28e7c6eeef79fccdd ../../../.build-id/9e/e0c4128f01a1fcc36d67c28e7c6eeef79fccdd
libchipcard-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/bd/1e8e164d44e796faf6c1ac0147477497ca6211 ../../../.build-id/bd/1e8e164d44e796faf6c1ac0147477497ca6211
libchipcard-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/c0/e553e9f8ad47d24da4fea1b16ce5e14aebb2c2 ../../../.build-id/c0/e553e9f8ad47d24da4fea1b16ce5e14aebb2c2
libchipcard-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/e3/d742a438d2f6d08ea1dc5293b5ea24ae66c60f ../../../.build-id/e3/d742a438d2f6d08ea1dc5293b5ea24ae66c60f
 4 packages and 0 specfiles checked; 21 errors, 50 warnings, 21 badness; has taken 48.4 s 



Unversioned so-files
--------------------
libchipcard: /usr/lib64/gwenhywfar/plugins/79/ct/chiptanusb.so
libchipcard: /usr/lib64/gwenhywfar/plugins/79/ct/ddvcard.so
libchipcard: /usr/lib64/gwenhywfar/plugins/79/ct/starcoscard.so
libchipcard: /usr/lib64/gwenhywfar/plugins/79/ct/zkacard.so

Source checksums
----------------
https://www.aquamaniac.de/rdm/attachments/download/381/libchipcard-5.1.6.tar.gz.asc :
  CHECKSUM(SHA256) this package     : 61fa18f1c3e137ff9e4843f562f47895d312350294f4cf71e65116b3005c8b92
  CHECKSUM(SHA256) upstream package : 61fa18f1c3e137ff9e4843f562f47895d312350294f4cf71e65116b3005c8b92
https://www.aquamaniac.de/rdm/attachments/download/382/libchipcard-5.1.6.tar.gz :
  CHECKSUM(SHA256) this package     : 6c07f527417f7562074f99012da4d11eb4dbafd33f49e66b442ccd6e3b8cfd20
  CHECKSUM(SHA256) upstream package : 6c07f527417f7562074f99012da4d11eb4dbafd33f49e66b442ccd6e3b8cfd20


Requires
--------
libchipcard (rpmlib, GLIBC filtered):
    /usr/bin/sh
    libc.so.6()(64bit)
    libchipcard.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgwenhywfar.so.79()(64bit)
    libpcsclite.so.1()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)

libchipcard-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    gwenhywfar-devel
    libchipcard(x86-64)
    libchipcard.so.6()(64bit)

libchipcard-debuginfo (rpmlib, GLIBC filtered):

libchipcard-debugsource (rpmlib, GLIBC filtered):



Provides
--------
libchipcard:
    libchipcard
    libchipcard(x86-64)
    libchipcard.so.6()(64bit)

libchipcard-devel:
    libchipcard-devel
    libchipcard-devel(x86-64)
    pkgconfig(libchipcard-client)
    pkgconfig(libchipcard-server)

libchipcard-debuginfo:
    debuginfo(build-id)
    libchipcard-debuginfo
    libchipcard-debuginfo(x86-64)
    libchipcard.so.6.1.6-5.1.6-3.fc38.x86_64.debug()(64bit)

libchipcard-debugsource:
    libchipcard-debugsource
    libchipcard-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2035958
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: Perl, Python, Ocaml, SugarActivity, fonts, Ruby, PHP, R, Haskell, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comments:
a) Some of the libraries are unversioned. Maybe an issue should be raised upstream, or Fedora specific versioning should be applied.
b) Builds fail on Fedora ELN, https://copr.fedorainfracloud.org/coprs/fed500/libchipcard/build/4887683/ but others are ok.
c) Since the signing key is not known at present, should the line
Source1: https://www.aquamaniac.de/rdm/attachments/download/381/libchipcard-%{version}.tar.gz.asc
also be commented out?
d) Licensing breakdown should be described in the spec file
Comment 14 ingli 2022-10-05 09:25:05 UTC 
ad a) versioning of so files: I asked for this at https://www.aquamaniac.de/rdm/issues/289
Comment 15 Benson Muite 2022-10-05 10:38:56 UTC 
Ingli - Thanks for raising issues in aquamaniac bug tracking system.  The checks are mostly to see if the library can be incorporated into Fedora. Might you be able to test whether the library works by using the copr repository:
https://copr.fedorainfracloud.org/coprs/fed500/libchipcard
Comment 16 Benson Muite 2022-10-05 10:45:19 UTC 
Sorry, Ingli should be Ingmar.
Comment 17 Gwyn Ciesla 2022-10-05 15:56:23 UTC 
The ELN builds fail because gwenhywfar is missing. Thank you for filing the solib versioning upstream.

I see no harm in including the signature inthe source, it will be easier to add gpg validation when the keyring is available.

What do you recommend for the License field?
Comment 18 ingli 2022-10-06 10:11:34 UTC 
Hi, re signature, I was pointed to this key
https://keyserver.ubuntu.com/pks/lookup?search=0x4A977416&fingerprint=on&op=index
Comment 19 Benson Muite 2022-10-06 10:30:09 UTC 
Thanks Ingmar.
For the licenses, one needs to explain which files correspond to which licenses.  Majority of files are typically under one license and can be lumped together under "all others".
Comment 20 Gwyn Ciesla 2022-10-06 15:40:59 UTC 
SRPM: https://fedorapeople.org/~limb/review/libchipcard/libchipcard-5.1.6-4.fc37.src.rpm
SPEC: https://fedorapeople.org/~limb/review/libchipcard/libchipcard.spec

That keyring gives an invalid signature. Uncomment the zcat line to test.
Updated licensing.
Comment 21 ingli 2022-10-06 19:55:35 UTC 
Amazing role I am taking – human translating between platforms :)

re the versioning of the so-files, the developer suggests at https://www.aquamaniac.de/rdm/issues/289#note-1

> Those are plugin modules which aren't generally versioned. How would that work anyway? The modules are loaded with dlopen() which doesn't provide a mechanism for versioning.

> However, those modules are versioned in regards to the Gwenhywfar version they are compiled for (using specific paths for different versions of Gwenhywfar). Since installing multiple versions of Libchipcard isn't supported anyway this should be enough.
Comment 22 Gwyn Ciesla 2022-10-06 20:00:03 UTC 
That makes sense to me.
Comment 23 Benson Muite 2022-10-07 09:04:46 UTC 
The following works for me:

%gpgverify seems to use gpgv https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/54#request_diff
The key is available at https://keyserver.ubuntu.com/pks/lookup?op=get&search=0xe9899d784a977416
If this text is saved as aqbanking.key then one can do the following
$ gpg --dearmor < aqbanking.key > aqbanking.gpg
$ gpgv --keyring=./aqbanking.gpg libchipcard-5.1.6.tar.gz.asc libchipcard-5.1.6.tar.gz 
gpgv: Signature made Fri 17 Sep 2021 06:46:42 PM EAT
gpgv:                using RSA key 42400AF5EB2A17F0A69BB551E9899D784A977416
gpgv: Good signature from "AqBanking Package Key <packages>"

One can also use
$gpg  --receive-keys 0x4A977416
gpg: key E9899D784A977416: public key "AqBanking Package Key <packages>" imported
gpg: Total number processed: 1
gpg:               imported: 1

$ gpg --verify libchipcard-5.1.6.tar.gz.asc 
gpg: assuming signed data in 'libchipcard-5.1.6.tar.gz'
gpg: Signature made Fri 17 Sep 2021 06:46:42 PM EAT
gpg:                using RSA key 42400AF5EB2A17F0A69BB551E9899D784A977416
gpg: Good signature from "AqBanking Package Key <packages>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 4240 0AF5 EB2A 17F0 A69B  B551 E989 9D78 4A97 7416

Though this would only work when the build has internet access, but is an easier way to verify things work before adding the key file to the sources.
Comment 24 Gwyn Ciesla 2022-10-07 15:04:11 UTC 
Right, and the build in koji will not have internet access.
Comment 25 Benson Muite 2022-10-07 16:29:14 UTC 
Obtain the text content of https://keyserver.ubuntu.com/pks/lookup?op=get&search=0xe9899d784a977416  and save it as keyfile.asc

Then update the following lines of the spec file 
# Download is PHP form at http://www.aquamaniac.de/sites/download/packages.php
Source0: https://www.aquamaniac.de/rdm/attachments/download/382/libchipcard-%{version}.tar.gz
Source1: https://www.aquamaniac.de/rdm/attachments/download/381/libchipcard-%{version}.tar.gz.asc
License: LGPL-2.0-only and GPL-2.0-or-later and LGPL-2.1-or-later
# Most LGPL 2
# LGPL 2.1+: src/lib/version.h
# GPLv2+: src/tools/cardcommander/cardcommander.cpp, src/tools/kvkcard/main.c, src/tools/memcard/main.c
# Keyfile obtained from https://keyserver.ubuntu.com/pks/lookup?op=get&search=0xe9899d784a977416 
Source2: keyfile.asc
URL: https://www.aquamaniac.de/rdm/projects/libchipcard

and

%autosetup -n %{name}-%{version}
%{gpgverify} --keyring='%{SOURCE2}' --signature='%{SOURCE1}' --data='%{SOURCE0}'

Further comments:
a) GeldKarte will be withdrawn in 2024 https://en.wikipedia.org/wiki/Geldkarte
b) Maybe it is helpful to have the library developers as co-maintainers? The related package  gwenhywfar has a spec file template in the source repository https://www.aquamaniac.de/rdm/projects/gwenhywfar/repository
Comment 26 Gwyn Ciesla 2022-10-07 19:39:25 UTC 
Thank you, that worked!

SRPM: https://fedorapeople.org/~limb/review/libchipcard/libchipcard-5.1.6-5.fc37.src.rpm
SPEC: https://fedorapeople.org/~limb/review/libchipcard/libchipcard.spec

Possibly, they may request that. gwenhywfar is already in Fedora.
Comment 27 Benson Muite 2022-10-08 00:21:42 UTC 
In the spec file, can you remove
# Signing key is not known
and add location signing key was obtained from
# Keyfile obtained from https://keyserver.ubuntu.com/pks/lookup?op=get&search=0xe9899d784a977416 

With those changes, approved
Comment 28 Benson Muite 2022-10-08 00:25:49 UTC 
Plugin library non-versioning seems ok based on https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning
Comment 29 Gwyn Ciesla 2022-10-10 14:02:26 UTC 
Thank you both!
Comment 30 Gwyn Ciesla 2022-10-10 14:04:19 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/libchipcard
Comment 31 Fedora Update System 2022-10-11 13:27:32 UTC 
FEDORA-2022-413ad16875 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-413ad16875
Comment 32 Fedora Update System 2022-10-11 15:52:44 UTC 
FEDORA-2022-413ad16875 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-413ad16875`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-413ad16875

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 33 Fedora Update System 2022-11-10 22:14:46 UTC 
FEDORA-2022-413ad16875 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.