Bug 2036098
| Summary: | Review Request: intel-opencl-clang - Library to compile OpenCL C kernels to SPIR-V modules | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | František Zatloukal <fzatlouk> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | dominik, ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | intel-opencl-clang-13.0.0-1.fc36 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-01-20 15:44:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2036099 | ||
|
Description
František Zatloukal
2021-12-29 17:50:02 UTC
SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03198963-intel-opencl-clang/intel-opencl-clang.spec SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03198963-intel-opencl-clang/intel-opencl-clang-13.0.0-1.fc36.src.rpm Added license, split -devel Taking this review. > %files
> %license LICENSE
> %{_libdir}/libopencl-clang.so*
This should be split: "%{_libdir}/libopencl-clang.so.*" in the main package, "%{_libdir}/libopencl-clang.so" in the devel subpackage.
> %cmake -DPREFERRED_LLVM_VERSION='13.0.0'
Is there a macro or something for determining the LLVM version we're going to use to pass as an argument? I can see this breaking when LLVM gets upgraded...
SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03199816-intel-opencl-clang/intel-opencl-clang.spec SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03199816-intel-opencl-clang/intel-opencl-clang-13.0.0-1.fc36.src.rpm Addressed both, I didn't find a macro, so there is this shell abomination instead. It cares only about llvm major (and breaks on ~rcX), so I am adding .0.0 to the major. Review notes: * Packaging complies with the guidelines * Package builds and installs * No serious issues from rpmlint * Licensing is correct and license files are correctly installed PACKAGE APPROVED. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/intel-opencl-clang Built in rawhide: intel-opencl-clang-13.0.0-1.fc36 |