Bug 2036098 - Review Request: intel-opencl-clang - Library to compile OpenCL C kernels to SPIR-V modules
Summary: Review Request: intel-opencl-clang - Library to compile OpenCL C kernels to S...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2036099
TreeView+ depends on / blocked
 
Reported: 2021-12-29 17:50 UTC by František Zatloukal
Modified: 2022-01-20 15:44 UTC (History)
3 users (show)

Fixed In Version: intel-opencl-clang-13.0.0-1.fc36
Clone Of:
Environment:
Last Closed: 2022-01-20 15:44:25 UTC
Type: Bug
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Comment 2 František Zatloukal 2022-01-19 16:18:34 UTC
Added license, split -devel

Comment 3 Neal Gompa 2022-01-19 17:24:39 UTC
Taking this review.

Comment 4 Neal Gompa 2022-01-19 17:26:11 UTC
> %files
> %license LICENSE
> %{_libdir}/libopencl-clang.so*


This should be split: "%{_libdir}/libopencl-clang.so.*" in the main package, "%{_libdir}/libopencl-clang.so" in the devel subpackage.

Comment 5 Neal Gompa 2022-01-19 17:27:35 UTC
> %cmake -DPREFERRED_LLVM_VERSION='13.0.0'

Is there a macro or something for determining the LLVM version we're going to use to pass as an argument? I can see this breaking when LLVM gets upgraded...

Comment 7 František Zatloukal 2022-01-19 21:13:28 UTC
Addressed both, I didn't find a macro, so there is this shell abomination instead. It cares only about llvm major (and breaks on ~rcX), so I am adding .0.0 to the major.

Comment 8 Neal Gompa 2022-01-20 13:23:13 UTC
Review notes:

* Packaging complies with the guidelines
* Package builds and installs
* No serious issues from rpmlint
* Licensing is correct and license files are correctly installed

PACKAGE APPROVED.

Comment 9 Gwyn Ciesla 2022-01-20 14:52:33 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/intel-opencl-clang

Comment 10 František Zatloukal 2022-01-20 15:44:25 UTC
Built in rawhide: intel-opencl-clang-13.0.0-1.fc36


Note You need to log in before you can comment on or make changes to this bug.