SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03086528-intel-opencl-clang/intel-opencl-clang.spec SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03086528-intel-opencl-clang/intel-opencl-clang-13.0.0-1.fc36.src.rpm
SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03198963-intel-opencl-clang/intel-opencl-clang.spec SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03198963-intel-opencl-clang/intel-opencl-clang-13.0.0-1.fc36.src.rpm
Added license, split -devel
Taking this review.
> %files > %license LICENSE > %{_libdir}/libopencl-clang.so* This should be split: "%{_libdir}/libopencl-clang.so.*" in the main package, "%{_libdir}/libopencl-clang.so" in the devel subpackage.
> %cmake -DPREFERRED_LLVM_VERSION='13.0.0' Is there a macro or something for determining the LLVM version we're going to use to pass as an argument? I can see this breaking when LLVM gets upgraded...
SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03199816-intel-opencl-clang/intel-opencl-clang.spec SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03199816-intel-opencl-clang/intel-opencl-clang-13.0.0-1.fc36.src.rpm
Addressed both, I didn't find a macro, so there is this shell abomination instead. It cares only about llvm major (and breaks on ~rcX), so I am adding .0.0 to the major.
Review notes: * Packaging complies with the guidelines * Package builds and installs * No serious issues from rpmlint * Licensing is correct and license files are correctly installed PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/intel-opencl-clang
Built in rawhide: intel-opencl-clang-13.0.0-1.fc36