Bug 2036099

SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03196792-intel-igc/igc.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03196792-intel-igc/intel-igc-1.0.9933-1.fc36.src.rpm

Spec cleaned up, updated to the latest upstream release, fixed to build with gcc 12.

Sorry for the drive-by comment, but I saw this package just streaming by on the package-review list.
Note that you should never use (TM) or (R) in package summaries or descriptions:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_trademarks_in_summary_or_description

SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03196958-intel-igc/intel-igc.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03196958-intel-igc/intel-igc-1.0.9933-1.fc36.src.rpm

(In reply to Fabio Valentini from comment #3)
> Sorry for the drive-by comment, but I saw this package just streaming by on
> the package-review list.
> Note that you should never use (TM) or (R) in package summaries or
> descriptions:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_trademarks_in_summary_or_description

Thanks, (TM)/(R) and their unicode representations removed. Also renamed the specfile to match actual package name.

Source1: https://github.com/intel/vc-intrinsics/archive/%{vc_commit}/vc-intrinsics-%{vc_shortcommit}.tar.gz
Source2: https://github.com/KhronosGroup/SPIRV-Tools/archive/v%{spirv_tools_tag}/SPIRV-Tools-v%{spirv_tools_tag}.tar.gz
Source3: https://github.com/KhronosGroup/SPIRV-Headers/archive/%{spirv_headers_tag}/SPIRV-Headers-%{spirv_headers_tag}.tar.gz


%files
%{_libdir}/libiga64.so*
%{_libdir}/libigc.so*
%{_libdir}/libigdfcl.so*

This will miss any SONAME changes.

%{_libdir}/igc/NOTICES.txt

This looks like a %doc or %license candidate.

%files devel
%{_includedir}/igc/*
%{_includedir}/iga/*
%{_includedir}/visa/*

This makes the igc, iga and visa subdirectories in %{_includedir} unowned. Drop the "/*" part.

I hit submit too quickly.

(In reply to Dominik 'Rathann' Mierzejewski from comment #6):
> Source1: https://github.com/intel/vc-intrinsics/archive/%{vc_commit}/vc-intrinsics-%{vc_shortcommit}.tar.gz
> Source2: https://github.com/KhronosGroup/SPIRV-Tools/archive/v%{spirv_tools_tag}/SPIRV-Tools-v%{spirv_tools_tag}.tar.gz
> Source3: https://github.com/KhronosGroup/SPIRV-Headers/archive/%{spirv_headers_tag}/SPIRV-Headers-%{spirv_headers_tag}.tar.gz

These need either Provides: bundled(*) tags or be unbundled.

SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-35-x86_64/03258640-intel-igc/intel-igc.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-35-x86_64/03258640-intel-igc/intel-igc-1.0.9933-1.fc35.src.rpm

All should hopefully be addressed.

For bundling, hopefully, the situation will improve in the future, there is upstream request already: https://github.com/intel/intel-graphics-compiler/issues/219

Taking this review.

> %license LICENSE.md
> %license %{_libdir}/igc/NOTICES.txt
> %{_libdir}/libiga64.so.1*
> %{_libdir}/libigc.so.1*
> %{_libdir}/libigdfcl.so.1*

This should be broken out to a libs subpackage and for the library sonames, you should use ".so.1{,.*}" instead of ".so.1*" to ensure you avoid some pitfalls around globbing.

The devel subpackage should depend on the libs subpackage, and the main package should depend on the libs subpackage.

SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-35-x86_64/03259620-intel-igc/intel-igc.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-35-x86_64/03259620-intel-igc/intel-igc-1.0.9933-1.fc35.src.rpm

Everything should be resolved :)

> Requires:      %{name} = %{version}-%{release}

This is not needed in the libs subpackage.

>     -DIGC_OPTION__LLVM_PREFERRED_VERSION='13.0.0' \

This should probably have the same trick you applied elsewhere to make sure the correct LLVM version is set there.

SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03260080-intel-igc/intel-igc.spec

SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/intel-media-driver-free/fedora-rawhide-x86_64/03260080-intel-igc/intel-igc-1.0.9933-1.fc36.src.rpm

(In reply to Neal Gompa from comment #14)
> > Requires:      %{name} = %{version}-%{release}
> 
> This is not needed in the libs subpackage.
> 
> >     -DIGC_OPTION__LLVM_PREFERRED_VERSION='13.0.0' \
> 
> This should probably have the same trick you applied elsewhere to make sure
> the correct LLVM version is set there.

Applied.

Review notes:

* Packaging complies with the guidelines
* Package builds and installs
* No serious issues from rpmlint
* Licensing is correct and license files are correctly installed

PACKAGE APPROVED.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/intel-igc

Built in rawhide: intel-igc-1.0.9933-1.fc36