Bug 2036610

Summary: Review Request: mingw-graphene - Thin layer of types for graphic libraries
Product: [Fedora] Fedora Reporter: Marc-Andre Lureau <marcandre.lureau>
Component: Package ReviewAssignee: Sandro Mani <manisandro>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: manisandro, package-review
Target Milestone: ---Flags: manisandro: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-01-04 17:33:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marc-Andre Lureau 2022-01-03 11:33:26 UTC 
Spec URL: https://elmarco.fedorapeople.org/mingw-graphene.spec
SRPM URL: https://elmarco.fedorapeople.org/mingw-graphene-1.10.6-1.fc36.src.rpm
Description:
Graphene provides a small set of mathematical types needed to implement graphic
libraries that deal with 2D and 3D transformations and projections.
It is a dependency of gtk4.

Fedora Account System Username: elmarco
Comment 1 Marc-Andre Lureau 2022-01-03 11:39:11 UTC 
scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=80786201
Comment 2 Marc-Andre Lureau 2022-01-03 11:39:31 UTC 
@manisandro have you looked at packaging gtk4 yet?
thanks
Comment 3 Sandro Mani 2022-01-03 11:42:42 UTC 
No not yet - still working on qt6. 

I'll take this review, can you take this one in exchange?

https://bugzilla.redhat.com/show_bug.cgi?id=2009268
Comment 4 Sandro Mani 2022-01-03 12:13:30 UTC 
- License is OK
- mingw-filesystem BR should be >= 107, as %mingw_ninja_install was introduced in that version
- File and dir ownership is OK
- Requires and provides are OK
- rpmlint passes

Approved, please change the mingw-filesystem BR when importing.
Comment 5 Gwyn Ciesla 2022-01-04 16:22:45 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-graphene