Bug 2036610 - Review Request: mingw-graphene - Thin layer of types for graphic libraries
Summary: Review Request: mingw-graphene - Thin layer of types for graphic libraries
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Sandro Mani
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-03 11:33 UTC by Marc-Andre Lureau
Modified: 2022-01-04 17:33 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-01-04 17:33:26 UTC
Type: ---
Embargoed:
manisandro: fedora-review+

Attachments (Terms of Use)

Description Marc-Andre Lureau 2022-01-03 11:33:26 UTC 
Spec URL: https://elmarco.fedorapeople.org/mingw-graphene.spec
SRPM URL: https://elmarco.fedorapeople.org/mingw-graphene-1.10.6-1.fc36.src.rpm
Description:
Graphene provides a small set of mathematical types needed to implement graphic
libraries that deal with 2D and 3D transformations and projections.
It is a dependency of gtk4.

Fedora Account System Username: elmarco
Comment 1 Marc-Andre Lureau 2022-01-03 11:39:11 UTC 
scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=80786201
Comment 2 Marc-Andre Lureau 2022-01-03 11:39:31 UTC 
@manisandro have you looked at packaging gtk4 yet?
thanks
Comment 3 Sandro Mani 2022-01-03 11:42:42 UTC 
No not yet - still working on qt6. 

I'll take this review, can you take this one in exchange?

https://bugzilla.redhat.com/show_bug.cgi?id=2009268
Comment 4 Sandro Mani 2022-01-03 12:13:30 UTC 
- License is OK
- mingw-filesystem BR should be >= 107, as %mingw_ninja_install was introduced in that version
- File and dir ownership is OK
- Requires and provides are OK
- rpmlint passes

Approved, please change the mingw-filesystem BR when importing.
Comment 5 Gwyn Ciesla 2022-01-04 16:22:45 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-graphene
Note You need to log in before you can comment on or make changes to this bug.