Bug 203667
Summary: | [PATCH] enhance system-config-rootpassword interface (Fedora Usability) | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Damien Durand <splinux25> | ||||
Component: | system-config-rootpassword | Assignee: | Paul Nasrat <nobody+pnasrat> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | |||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | lmacken, sundaram, wtogami | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2006-10-30 11:14:21 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 150225 | ||||||
Attachments: |
|
Description
Damien Durand
2006-08-22 21:55:45 UTC
Created attachment 134681 [details]
Patch to enhance system-config-rootpassword interface
I can't comment on the code quality, but the text needs a little revision. Suggest changing at least: from: "You can change the root password in filling \nthe following fields:" to: "You can change the root password by filling \nthe following fields:" from: "the fields are not the same, please filling \nagain" to: "The two fields did not match. Please try \nagain" etc. (Maybe reuse the old text, if it's already been translated) Thank you for your comments, the labels are fixed by this new path : http://glive.tuxfamily.org/code/new_system_config_root_password2.patch For the old text, I think, it's not really coherent with the new interface, tooltips etc... but yeah that can be a problem with the translation teams. Regards, Damien Just one thing, in the demo, when the pass-o-meter show the strong but the tooltip says that it's based on a reversed dictionnary word, it was because the tooltip was not updated. It had been fixed in the patch. A password is only considered as strong when it is long enough (the limit was put at 8 caracters) and it validates the cracklib test. Well it had a new dependency in the rpm, but cracklib is already in core as a dependence of pam. The pass-o-meter is only here to give a feedback to "average" end-users and not sysadmins. Ping? In your animation, the 'Change root password' button become enabled while typing the password a second time, before the second password is even the same length as the first. This should probably be fixed. Sorry for the delay - I've commited this to HEAD with a small change to address Comment #6. Will be in rawhide shortly. I'm really happy, thanks you for your devoted time ;-) |