Bug 2038968

Summary: Move feature gates from a carry patch to openshift/api
Product: OpenShift Container Platform Reporter: Jan Safranek <jsafrane>
Component: StorageAssignee: Jan Safranek <jsafrane>
Storage sub component: Operators QA Contact: Wei Duan <wduan>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: unspecified CC: aos-bugs, fbertina, tsmetana
Version: 4.10   
Target Milestone: ---   
Target Release: 4.10.0   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-10 16:38:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jan Safranek 2022-01-10 16:28:46 UTC
We should not disable CSI migration gate(s) via a <carry> patch in openshift/kubernetes:

[+ there is a similar patch proposed for 1.23 rebase].

We should change the default feature gates in openshift/api in `defaultFeatures` instead:

Version-Release number of selected component (if applicable):

This change should have no visible outcome to our customers. CSI migration feature gates should be still disabled by default and enabled when TechPreviewNoUpgrade is used. In the end, our carry patch (referenced above) should be removed from openshift/kubernetes repo.

Comment 1 Jan Safranek 2022-01-10 17:13:03 UTC
It needs to be updated in kube-apiserver-operator, kube-controllermanager-operator and machine-config-operator.

Comment 3 Jan Safranek 2022-01-13 13:19:49 UTC
We need to remove the carry patched in openshift/kubernetes

Comment 7 Jan Safranek 2022-01-25 17:02:32 UTC
I am moving openshift/api/pull/1104 to https://bugzilla.redhat.com/show_bug.cgi?id=2045551, it's a cosmetic bug that can be fixed in 4.11. It requires openshift/api bump in several components and it's pretty late in the release cycle for that.

Comment 8 Wei Duan 2022-01-26 02:03:14 UTC
Verified on 4.10.0-0.nightly-2022-01-25-023600 

1. Before enable the featuregate:
a. check kcm:
$ oc -n openshift-kube-controller-manager get pod kube-controller-manager-wduan-0125c-w27vs-master-0 -o custom-columns=NAME:.spec.containers[0].args --no-headers | fgrep -- "--feature-gates=CSIMigration"
--feature-gates=CSIMigrationAWS=false --feature-gates=CSIMigrationAzureDisk=false --feature-gates=CSIMigrationAzureFile=false --feature-gates=CSIMigrationGCE=false --feature-gates=CSIMigrationOpenStack=false --feature-gates=CSIMigrationvSphere=false

2. After enable the featuregat with cmd "$ oc patch featuregate cluster -p '{"spec": {"featureSet": "TechPreviewNoUpgrade"}}' --type merge"
a. check kcm 
$ oc -n openshift-kube-controller-manager get pod kube-controller-manager-wduan-0125c-w27vs-master-0 -o custom-columns=NAME:.spec.containers[0].args --no-headers | fgrep -- "--feature-gates=CSIMigration"
--feature-gates=CSIMigrationAWS=true --feature-gates=CSIMigrationAzureDisk=true --feature-gates=CSIMigrationAzureFile=true --feature-gates=CSIMigrationGCE=true --feature-gates=CSIMigrationOpenStack=true --feature-gates=CSIMigrationvSphere=true

b. check node
$ oc get csinode wduan-0125c-w27vs-worker-centralus1-98d5v -o json | jq .metadata.annotations
  "storage.alpha.kubernetes.io/migrated-plugins": "kubernetes.io/aws-ebs,kubernetes.io/azure-disk,kubernetes.io/azure-file,kubernetes.io/cinder,kubernetes.io/gce-pd,kubernetes.io/vsphere-volume"

Verified pass.

Comment 9 Jan Safranek 2022-01-26 10:17:22 UTC
All PRs were merged -> ON_QA.

Comment 10 Wei Duan 2022-01-26 10:22:31 UTC
Update the status to "Verified" base on the test result.

Comment 13 errata-xmlrpc 2022-03-10 16:38:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.