Hide Forgot
We should not disable CSI migration gate(s) via a <carry> patch in openshift/kubernetes: https://github.com/openshift/kubernetes/commit/4d2a2f3cfa35b6e2667f44265373f369db9c9be9 [+ there is a similar patch proposed for 1.23 rebase]. We should change the default feature gates in openshift/api in `defaultFeatures` instead: https://github.com/openshift/api/blob/3bf13cf5081a3e76216a2498c473de9f9e995e54/config/v1/types_feature.go#L142-L155 Version-Release number of selected component (if applicable): 4.10 This change should have no visible outcome to our customers. CSI migration feature gates should be still disabled by default and enabled when TechPreviewNoUpgrade is used. In the end, our carry patch (referenced above) should be removed from openshift/kubernetes repo.
It needs to be updated in kube-apiserver-operator, kube-controllermanager-operator and machine-config-operator.
We need to remove the carry patched in openshift/kubernetes
I am moving openshift/api/pull/1104 to https://bugzilla.redhat.com/show_bug.cgi?id=2045551, it's a cosmetic bug that can be fixed in 4.11. It requires openshift/api bump in several components and it's pretty late in the release cycle for that.
Verified on 4.10.0-0.nightly-2022-01-25-023600 1. Before enable the featuregate: a. check kcm: $ oc -n openshift-kube-controller-manager get pod kube-controller-manager-wduan-0125c-w27vs-master-0 -o custom-columns=NAME:.spec.containers[0].args --no-headers | fgrep -- "--feature-gates=CSIMigration" --feature-gates=CSIMigrationAWS=false --feature-gates=CSIMigrationAzureDisk=false --feature-gates=CSIMigrationAzureFile=false --feature-gates=CSIMigrationGCE=false --feature-gates=CSIMigrationOpenStack=false --feature-gates=CSIMigrationvSphere=false 2. After enable the featuregat with cmd "$ oc patch featuregate cluster -p '{"spec": {"featureSet": "TechPreviewNoUpgrade"}}' --type merge" a. check kcm $ oc -n openshift-kube-controller-manager get pod kube-controller-manager-wduan-0125c-w27vs-master-0 -o custom-columns=NAME:.spec.containers[0].args --no-headers | fgrep -- "--feature-gates=CSIMigration" --feature-gates=CSIMigrationAWS=true --feature-gates=CSIMigrationAzureDisk=true --feature-gates=CSIMigrationAzureFile=true --feature-gates=CSIMigrationGCE=true --feature-gates=CSIMigrationOpenStack=true --feature-gates=CSIMigrationvSphere=true b. check node $ oc get csinode wduan-0125c-w27vs-worker-centralus1-98d5v -o json | jq .metadata.annotations { "storage.alpha.kubernetes.io/migrated-plugins": "kubernetes.io/aws-ebs,kubernetes.io/azure-disk,kubernetes.io/azure-file,kubernetes.io/cinder,kubernetes.io/gce-pd,kubernetes.io/vsphere-volume" } Verified pass.
All PRs were merged -> ON_QA.
Update the status to "Verified" base on the test result.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:0056