Bug 2041235

Summary: Review Request: calindori - Calendar application for Plasma Mobile
Product: [Fedora] Fedora Reporter: Onuralp SEZER <thunderbirdtr>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: justin.zobel, ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-03-18 12:24:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Onuralp SEZER 2022-01-16 16:46:14 UTC 
Spec URL: https://pagure.io/calindori_rpm/raw/main/f/calindori.spec
SRPM URL: https://pagure.io/calindori_rpm/blob/main/f/calindori-21.12-1.fc35.src.rpm
Description: Calendar application for Plasma Mobile
Fedora Account System Username: thunderbirdtr
Comment 1 Neal Gompa 2022-01-22 17:36:05 UTC 
Taking this review.
Comment 2 Neal Gompa 2022-01-22 17:42:25 UTC 
Initial spec review:

> %description
> %{summary}

This should be "%{summary}." in the description simply to make rpmlint shut up.

> %prep
> %autosetup -n %{name}-%{version}

"-n %{name}-%{version}" is superfluous, since that's the default. Drop it.

> %find_lang %{name}
> %find_lang calindac

Add "cat %{name}.lang calindac > %{name}-full.lang" so that later you can...

> %files -f %{name}.lang

Use "%{name}-full.lang" here, and...

> %{_kf5_datadir}/locale/*/LC*/calindac*

Drop this.
Comment 3 Neal Gompa 2022-01-22 17:44:44 UTC 
Also, license files are not captured with a "%license" stanza. Add the following:

> %license LICENSES/*
Comment 4 Justin Zobel 2022-02-06 00:05:13 UTC 
I assume you meant "cat %{name}.lang calindac.lang > %{name}-full.lang" and added that in my MR on Onuralp's repo.
Comment 5 Justin Zobel 2022-03-11 00:49:17 UTC 
Have run a fedora-review against this and found no issues in review.txt, some licenses missing, have notified Onuralp.
Comment 6 Neal Gompa 2022-03-14 22:43:40 UTC 
Everything looks gravy, so...

PACKAGE APPROVED.
Comment 7 Tomas Hrcka 2022-03-15 07:27:43 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/calindori
Comment 8 Package Review 2023-03-18 12:24:01 UTC 
Package is now in repositories, closing review.