Spec URL: https://pagure.io/calindori_rpm/raw/main/f/calindori.spec SRPM URL: https://pagure.io/calindori_rpm/blob/main/f/calindori-21.12-1.fc35.src.rpm Description: Calendar application for Plasma Mobile Fedora Account System Username: thunderbirdtr
Taking this review.
Initial spec review: > %description > %{summary} This should be "%{summary}." in the description simply to make rpmlint shut up. > %prep > %autosetup -n %{name}-%{version} "-n %{name}-%{version}" is superfluous, since that's the default. Drop it. > %find_lang %{name} > %find_lang calindac Add "cat %{name}.lang calindac > %{name}-full.lang" so that later you can... > %files -f %{name}.lang Use "%{name}-full.lang" here, and... > %{_kf5_datadir}/locale/*/LC*/calindac* Drop this.
Also, license files are not captured with a "%license" stanza. Add the following: > %license LICENSES/*
I assume you meant "cat %{name}.lang calindac.lang > %{name}-full.lang" and added that in my MR on Onuralp's repo.
Have run a fedora-review against this and found no issues in review.txt, some licenses missing, have notified Onuralp.
Everything looks gravy, so... PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/calindori
Package is now in repositories, closing review.