Bug 2041251

Summary: Review Request: kasts - A mobile podcast application
Product: [Fedora] Fedora Reporter: Onuralp SEZER <thunderbirdtr>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-07 17:45:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Onuralp SEZER 2022-01-16 19:03:32 UTC
Spec URL: https://pagure.io/kasts/raw/main/f/kasts.spec
SRPM URL: https://pagure.io/kasts/blob/main/f/kasts-21.12-1.fc35.src.rpm
Description: A mobile podcast application
Fedora Account System Username: thunderbirdtr

Comment 1 Neal Gompa 2022-01-22 17:47:32 UTC
Initial spec review:

> %description
> %{summary}

This should be "%{summary}." in the description simply to make rpmlint shut up.

> %prep
> %autosetup -n %{name}-%{version}

"-n %{name}-%{version}" is superfluous, since that's the default. Drop it.

Also, license files are not captured with a "%license" stanza. Add "%license LICENSES/*" to the file list.

Comment 2 Onuralp SEZER 2022-01-22 22:32:52 UTC
All done!

Comment 3 Neal Gompa 2022-01-22 23:04:11 UTC
Review notes:

[x]: Package follows Fedora Packaging Guidelines
[x]: Package builds and installs
[x]: No serious issues from rpmlint
[x]: License is correctly identified and installed

PACKAGE APPROVED.

Comment 4 Gwyn Ciesla 2022-01-24 16:59:00 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/kasts

Comment 5 Package Review 2023-01-07 17:45:32 UTC
Package is now in repositories, closing review.