Bug 2041251 - Review Request: kasts - A mobile podcast application
Summary: Review Request: kasts - A mobile podcast application
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-16 19:03 UTC by Onuralp SEZER
Modified: 2023-01-07 17:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-01-07 17:45:32 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Onuralp SEZER 2022-01-16 19:03:32 UTC 
Spec URL: https://pagure.io/kasts/raw/main/f/kasts.spec
SRPM URL: https://pagure.io/kasts/blob/main/f/kasts-21.12-1.fc35.src.rpm
Description: A mobile podcast application
Fedora Account System Username: thunderbirdtr
Comment 1 Neal Gompa 2022-01-22 17:47:32 UTC 
Initial spec review:

> %description
> %{summary}

This should be "%{summary}." in the description simply to make rpmlint shut up.

> %prep
> %autosetup -n %{name}-%{version}

"-n %{name}-%{version}" is superfluous, since that's the default. Drop it.

Also, license files are not captured with a "%license" stanza. Add "%license LICENSES/*" to the file list.
Comment 2 Onuralp SEZER 2022-01-22 22:32:52 UTC 
All done!
Comment 3 Neal Gompa 2022-01-22 23:04:11 UTC 
Review notes:

[x]: Package follows Fedora Packaging Guidelines
[x]: Package builds and installs
[x]: No serious issues from rpmlint
[x]: License is correctly identified and installed

PACKAGE APPROVED.
Comment 4 Gwyn Ciesla 2022-01-24 16:59:00 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/kasts
Comment 5 Package Review 2023-01-07 17:45:32 UTC 
Package is now in repositories, closing review.
Note You need to log in before you can comment on or make changes to this bug.