Bug 204178

Summary:	Konsole does not display bold characters
Product:	[Fedora] Fedora	Reporter:	Boyan Anastasov <btanastasov>
Component:	kdebase	Assignee:	Than Ngo <than>
Status:	CLOSED RAWHIDE	QA Contact:	Ben Levenson <benl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-09-12 09:01:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Boyan Anastasov 2006-08-26 13:22:32 UTC

Description of problem:

After upgrading to kdebase-3.5.4-4.fc6 (rawhide) Bold characters appear as
Regular style.

Version-Release number of selected component (if applicable):
Fedora Core rawhide, kdebase-3.5.4-4.fc6 and up.

How reproducible:
From konsole menu, Settings->Font->Select I'm choosing MiscFixed Bold, Size 13.
Result: Bold characters appear as Normal style. Tested with other fonts too.

Additional info:
There is similar bugzilla #203221 for FC5, which was fixed according to Comment
#1. I added comment that this is not fixed but didn't noticed that it is about
FC5. Anyway - status is Closed, so nobody is reading this BZ anymore. I think
the proposed patch is wrong. In the KDE SNV repository there is a patch for this
problem and looks different:

http://websvn.kde.org/trunk/KDE/kdebase/apps/konsole/konsole/
TEScreen.cpp?r1=565267&r2=565268

           ef_re = cu_re;

 	   //OLD VERSION:
 	   //ef_re = cu_re & (RE_UNDERLINE | RE_BLINK);

Comment 1 Boyan Anastasov 2006-08-31 08:25:16 UTC

I recompiled kdebase without this patch and now bold characters are back.
(this is part of kdebase-3.5.4-konsole-bz#203221.patch)

--- konsole/konsole/TEWidget.cpp        (Revision 570193)
+++ konsole/konsole/TEWidget.cpp        (Revision 570194)
@@ -677,6 +677,18 @@
   }

   // Paint text
+  if (attr->r & RE_BOLD)
+  {
+    QFont currentFont = paint.font();
+    currentFont.setBold(true);
+    paint.setFont( currentFont );
+  } else {
+    QFont currentFont = paint.font();
+    currentFont.setBold(false);
+    paint.setFont( currentFont );
+  }
+
+
   if (!(blinking && (attr->r & RE_BLINK)))
   {
     // ### Disabled for now, since it causes problems with characters

Comment 2 Than Ngo 2006-09-12 09:01:51 UTC

it's now fixed in new KDE upstream. The fix will be included in 
kdebase-3.5.4-8. Thanks for you report.