Bug 2041930
| Summary: | Hunspell Dictionary dir change | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Cotton <bcotton> |
| Component: | Changes Tracking | Assignee: | Parag Nemade <pnemade> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Bhushan Barve <bbarve> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 36 | CC: | alex.ploumistos, bbarve, bcotton, lucab, petersen, pnemade, thashimo, travier, vishalvijayraghavan |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | hunspell-1.7.0-17.fc36 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-05-10 14:41:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2045568 | ||
| Bug Blocks: | 1982279 | ||
|
Description
Ben Cotton
2022-01-18 14:48:15 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 36 development cycle. Changing version to 36. Today we reached the Code Complete (testable) milestone in the F36 schedule: https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html All code for this change should be complete enough for testing. You can indicate this by setting the bug status to MODIFIED. (If the code is fully complete, you can go ahead and set it to ON_QA.) If you need to defer this Change to F37, please needinfo bcotton. The newly introduced lua scripts broke rpm-ostree F36 composes: https://github.com/coreos/rpm-ostree/issues/3418 From what I can see, there seems to be no reason for strictly needing lua scripting there. If that is the case, it would be nicer if such logic could be moved to a plain scriptlet. Personally I don't have a strong objection to switching to shell *if* it is safe here. We used LUA because it is recommended on: https://docs.fedoraproject.org/en-US/packaging-guidelines/Directory_Replacement/ If someone confirms that using shell is safe in this case we can try to change it. Otherwise it is probably better for rpm-ostree to have a workaround like the one tried used by the reporter in the upstream upstream ticket. Thanks for the additional insights. The packaging guideline suggestion applies to %pretrans logic, where binaries may not be yet available. The issue with rpm-ostree is related to the %post logic, which should not have such limitations (to the best of my knowledge). It should be fine to leave the %pretrans as is, and only tweak the %post one. I'm not sure if there are other reasons for having the %post logic in lua, and the commit which introduced it does not any further notes on that. Okay makes sense, thanks - I will switch %post back to shell. I pushed https://src.fedoraproject.org/rpms/hunspell/c/54c1c04c683c48762dd0436f88ae6d6c5bf91ae1?branch=rawhide which is building now in hunspell-1.7.0-17.fc37 (For reference there was earlier discussion too about %post in bug 2045568.) I hope hunspell-filesystem is all good now for F36. F36 was released today. If this Change did not land in the release, please notify bcotton as soon as possible. Hello, I've just noticed that after the upgrade to F36, Firefox can only provide spell-checking in english. I have the following hunspell packages installed: hunspell-1.7.0-19.fc36.x86_64 hunspell-el-0.9-10.fc36.noarch hunspell-en-0.20140811.1-22.fc36.noarch hunspell-en-GB-0.20140811.1-22.fc36.noarch hunspell-en-US-0.20140811.1-22.fc36.noarch hunspell-filesystem-1.7.0-19.fc36.x86_64 hunspell-fr-6.2-10.fc36.noarch As expected, /usr/share/myspell/ was empty and all the dictionary files were in /usr/share/hunspell/. I was able to make Firefox "see" the other dictionaries by manually creating symlinks in /usr/share/myspell/. Should this be reported against Firefox? Yes, please file a bug in the firefox component. If you file a bug, do please link it here too. It would be good to include the output of ls -l /usr/lib64/firefox/dictionaries (In reply to Jens Petersen from comment #12) > If you file a bug, do please link it here too. > I filed bug 2086929, missing bug 2084538 which was already open. > It would be good to include the output of > > ls -l /usr/lib64/firefox/dictionaries # ls -l /usr/lib64/firefox/dictionaries lrwxrwxrwx. 1 root root 19 May 9 18:35 /usr/lib64/firefox/dictionaries -> /usr/share/hunspell |