Bug 2041930 - Hunspell Dictionary dir change
Summary: Hunspell Dictionary dir change
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Changes Tracking
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Parag Nemade
QA Contact: Bhushan Barve
URL:
Whiteboard:
Depends On: 2045568
Blocks: F36Changes
TreeView+ depends on / blocked
 
Reported: 2022-01-18 14:48 UTC by Ben Cotton
Modified: 2022-05-17 06:59 UTC (History)
9 users (show)

Fixed In Version: hunspell-1.7.0-17.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-10 14:41:45 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker FC-451 0 None None None 2022-05-17 05:11:14 UTC

Description Ben Cotton 2022-01-18 14:48:15 UTC
This is a tracking bug for Change: Hunspell Dictionary dir change
For more details, see: https://fedoraproject.org/wiki/Changes/Hunspell_dictionary_dir_change

Update Hunspell Dictionary system directory from /usr/share/myspell/ to /usr/share/hunspell/

If you encounter a bug related to this Change, please do not comment here. Instead create a new bug and set it to block this bug.

Comment 1 Ben Cotton 2022-02-08 21:07:05 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 36 development cycle.
Changing version to 36.

Comment 2 Ben Cotton 2022-02-08 21:15:06 UTC
Today we reached the Code Complete (testable) milestone in the F36 schedule: https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

All code for this change should be complete enough for testing. You can indicate this by setting the bug status to MODIFIED. (If the code is fully complete, you can go ahead and set it to ON_QA.)

If you need to defer this Change to F37, please needinfo bcotton.

Comment 3 Luca BRUNO 2022-02-09 08:08:46 UTC
The newly introduced lua scripts broke rpm-ostree F36 composes: https://github.com/coreos/rpm-ostree/issues/3418

From what I can see, there seems to be no reason for strictly needing lua scripting there.
If that is the case, it would be nicer if such logic could be moved to a plain scriptlet.

Comment 4 Jens Petersen 2022-02-09 10:30:28 UTC
Personally I don't have a strong objection to switching to shell *if* it is safe here.

We used LUA because it is recommended on:

https://docs.fedoraproject.org/en-US/packaging-guidelines/Directory_Replacement/

If someone confirms that using shell is safe in this case we can try to change it.
Otherwise it is probably better for rpm-ostree to have a workaround like the one
tried used by the reporter in the upstream upstream ticket.

Comment 5 Luca BRUNO 2022-02-09 15:07:31 UTC
Thanks for the additional insights.
The packaging guideline suggestion applies to %pretrans logic, where binaries may not be yet available.
The issue with rpm-ostree is related to the %post logic, which should not have such limitations (to the best of my knowledge).
It should be fine to leave the %pretrans as is, and only tweak the %post one.

I'm not sure if there are other reasons for having the %post logic in lua, and the commit which introduced it does not any further notes on that.

Comment 6 Jens Petersen 2022-02-10 07:42:37 UTC
Okay makes sense, thanks - I will switch %post back to shell.

Comment 7 Jens Petersen 2022-02-10 08:54:41 UTC
I pushed

https://src.fedoraproject.org/rpms/hunspell/c/54c1c04c683c48762dd0436f88ae6d6c5bf91ae1?branch=rawhide

which is building now in hunspell-1.7.0-17.fc37

Comment 8 Jens Petersen 2022-02-11 03:28:47 UTC
(For reference there was earlier discussion too about %post in bug 2045568.)

I hope hunspell-filesystem is all good now for F36.

Comment 9 Ben Cotton 2022-05-10 14:41:45 UTC
F36 was released today. If this Change did not land in the release, please notify bcotton as soon as possible.

Comment 10 Alexander Ploumistos 2022-05-16 18:14:36 UTC
Hello,

I've just noticed that after the upgrade to F36, Firefox can only provide spell-checking in english.

I have the following hunspell packages installed:
hunspell-1.7.0-19.fc36.x86_64
hunspell-el-0.9-10.fc36.noarch
hunspell-en-0.20140811.1-22.fc36.noarch
hunspell-en-GB-0.20140811.1-22.fc36.noarch
hunspell-en-US-0.20140811.1-22.fc36.noarch
hunspell-filesystem-1.7.0-19.fc36.x86_64
hunspell-fr-6.2-10.fc36.noarch

As expected, /usr/share/myspell/ was empty and all the dictionary files were in /usr/share/hunspell/. I was able to make Firefox "see" the other dictionaries by manually creating symlinks in /usr/share/myspell/.

Should this be reported against Firefox?

Comment 11 Ben Cotton 2022-05-16 19:46:17 UTC
Yes, please file a bug in the firefox component.

Comment 12 Jens Petersen 2022-05-17 05:02:21 UTC
If you file a bug, do please link it here too.

It would be good to include the output of

ls -l /usr/lib64/firefox/dictionaries

Comment 13 Alexander Ploumistos 2022-05-17 06:59:10 UTC
(In reply to Jens Petersen from comment #12)
> If you file a bug, do please link it here too.
> 

I filed bug 2086929, missing bug 2084538 which was already open.



> It would be good to include the output of
> 
> ls -l /usr/lib64/firefox/dictionaries

# ls -l /usr/lib64/firefox/dictionaries
lrwxrwxrwx. 1 root root 19 May  9 18:35 /usr/lib64/firefox/dictionaries -> /usr/share/hunspell


Note You need to log in before you can comment on or make changes to this bug.