Bug 2043064

Summary:	Topology performance: Unnecessary rerenderings in topology nodes (unchanged mobx props)
Product:	OpenShift Container Platform	Reporter:	Christoph Jerolimov <cjerolim>
Component:	Dev Console	Assignee:	Christoph Jerolimov <cjerolim>
Status:	CLOSED ERRATA	QA Contact:	spathak <spathak>
Severity:	low	Docs Contact:
Priority:	low
Version:	4.10	CC:	aos-bugs, nmukherj
Target Milestone:	---
Target Release:	4.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-03-10 16:41:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Christoph Jerolimov 2022-01-20 15:00:19 UTC

Description of problem:
While debugging performance issues in our topology I found some unnecessary rerenderings in topology nodes. It looks like the BaseNode sets the dimension and position parameters with a new cloned object, also if the attributes don't change.

This is fixed in patternfly-topology 4.36.1.

See also:
* https://github.com/patternfly/patternfly-react/issues/6814
* https://github.com/patternfly/patternfly-react/pull/6801

Version-Release number of selected component (if applicable):
4.10   (Might hhappen also on older versions)

How reproducible:
Always

Steps to Reproduce:
This is not easy testable without changing the console source code.

Option 1: Install the mobx devtools and analyse the reason why the topology is rerendered.

Option 2: Tested with console.log in WordloadPodsNode.


Actual results:
Renders ~6 times on initial load.

Expected results:
Renders ~5 times on initial load.

Additional info:

Comment 3 Christoph Jerolimov 2022-01-24 19:52:53 UTC

This could not be verified on a cluster. But topology on 4.10.0-0.nightly-2022-01-24-181700 looks fine.

Comment 6 errata-xmlrpc 2022-03-10 16:41:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056