Bug 2043064 - Topology performance: Unnecessary rerenderings in topology nodes (unchanged mobx props)
Summary: Topology performance: Unnecessary rerenderings in topology nodes (unchanged m...
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Dev Console
Version: 4.10
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.10.0
Assignee: Christoph Jerolimov
QA Contact: spathak@redhat.com
Depends On:
TreeView+ depends on / blocked
Reported: 2022-01-20 15:00 UTC by Christoph Jerolimov
Modified: 2022-03-10 16:41 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2022-03-10 16:41:21 UTC
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Github openshift console pull 10879 0 None open Bug 2043064: Update patternfly-topology to include latest bugfixes/improvements 2022-01-20 15:01:08 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:41:37 UTC

Description Christoph Jerolimov 2022-01-20 15:00:19 UTC
Description of problem:
While debugging performance issues in our topology I found some unnecessary rerenderings in topology nodes. It looks like the BaseNode sets the dimension and position parameters with a new cloned object, also if the attributes don't change.

This is fixed in patternfly-topology 4.36.1.

See also:
* https://github.com/patternfly/patternfly-react/issues/6814
* https://github.com/patternfly/patternfly-react/pull/6801

Version-Release number of selected component (if applicable):
4.10   (Might hhappen also on older versions)

How reproducible:

Steps to Reproduce:
This is not easy testable without changing the console source code.

Option 1: Install the mobx devtools and analyse the reason why the topology is rerendered.

Option 2: Tested with console.log in WordloadPodsNode.

Actual results:
Renders ~6 times on initial load.

Expected results:
Renders ~5 times on initial load.

Additional info:

Comment 3 Christoph Jerolimov 2022-01-24 19:52:53 UTC
This could not be verified on a cluster. But topology on 4.10.0-0.nightly-2022-01-24-181700 looks fine.

Comment 6 errata-xmlrpc 2022-03-10 16:41:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.