Bug 2043541

Summary: Review Request: module-build - A library and a cli tool for building module streams
Product: [Fedora] Fedora Reporter: Martin Curlej <mcurlej>
Component: Package ReviewAssignee: Jakub Kadlčík <jkadlcik>
Status: ASSIGNED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jkadlcik, package-review, zbyszek
Target Milestone: ---Flags: jkadlcik: fedora-review?
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Martin Curlej 2022-01-21 13:45:15 UTC
Spec URL: https://mcurlej.fedorapeople.org/module-build.spec
SRPM URL: https://mcurlej.fedorapeople.org/module-build-0.1.0-1.fc34.src.rpm
Description: A library and a cli tool for building module streams. 
Fedora Account System Username: mcurlej

Comment 1 Zbigniew Jędrzejewski-Szmek 2022-01-26 21:42:00 UTC
Please retitle the bug.

Comment 2 Jakub Kadlčík 2022-12-14 19:39:21 UTC
Hello Martin,
thank you for the package.

> Version: 0.1.0

There is already 0.2.1 on GitHub, can you please update?

> Summary: Tool/library for building module streams locally.

A summary shouldn't end with a period.

> Source0: https://github.com/mcurlej/module-build/archive/%{version}/%{name}-%{version}.tar.gz

You can do

    Source0: %{URL}/archive/%{version}/%{name}-%{version}.tar.gz

to make the line shorter.

> %description
> A library and a cli tool for building module streams. 

Can you please write 2-3 sentences about the package?

> %check
> %pytest

The tests are failing in Mock, can you please take a look?

> Tue Feb 01 2022 Martin Čurlej <mcurlej> - 0.1.0-1

It may be a good idea to go without the special characters