Bug 2043541 - Review Request: module-build - A library and a cli tool for building module streams
Summary: Review Request: module-build - A library and a cli tool for building module s...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jakub Kadlčík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-21 13:45 UTC by Martin Curlej
Modified: 2023-12-17 17:08 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
jkadlcik: fedora-review?


Attachments (Terms of Use)

Description Martin Curlej 2022-01-21 13:45:15 UTC
Spec URL: https://mcurlej.fedorapeople.org/module-build.spec
SRPM URL: https://mcurlej.fedorapeople.org/module-build-0.1.0-1.fc34.src.rpm
Description: A library and a cli tool for building module streams. 
Fedora Account System Username: mcurlej

Comment 1 Zbigniew Jędrzejewski-Szmek 2022-01-26 21:42:00 UTC
Please retitle the bug.

Comment 2 Jakub Kadlčík 2022-12-14 19:39:21 UTC
Hello Martin,
thank you for the package.


> Version: 0.1.0

There is already 0.2.1 on GitHub, can you please update?


> Summary: Tool/library for building module streams locally.

A summary shouldn't end with a period.


> Source0: https://github.com/mcurlej/module-build/archive/%{version}/%{name}-%{version}.tar.gz

You can do

    Source0: %{URL}/archive/%{version}/%{name}-%{version}.tar.gz

to make the line shorter.


> %description
> A library and a cli tool for building module streams. 

Can you please write 2-3 sentences about the package?


> %check
> %pytest

The tests are failing in Mock, can you please take a look?


> Tue Feb 01 2022 Martin Čurlej <mcurlej> - 0.1.0-1

It may be a good idea to go without the special characters

Comment 3 Package Review 2023-12-15 00:45:24 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 4 Jakub Kadlčík 2023-12-17 17:08:45 UTC
I am interested in reviewing this ticket but there is no response from the contributor.


Note You need to log in before you can comment on or make changes to this bug.