Bug 204439

Summary:	Review Request: perl-POE-Component-SimpleDBI - Asynchronous non-blocking DBI calls in POE made simple
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/POE-Component-SimpleDBI/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-09-03 05:14:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Chris Weyl 2006-08-29 05:01:39 UTC

SRPM URL: http://home.comcast.net/~ckweyl/perl-POE-Component-SimpleDBI-1.12-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-POE-Component-SimpleDBI.spec

Description:
This module works its magic by creating a new session with POE, then
spawning off a child process to do the "heavy" lifting. That way, your main
POE process can continue servicing other clients. Queries are put into a
queue, and processed one at a time.

Comment 1 Jason Tibbitts 2006-09-02 20:14:04 UTC

Another standard spanspec-generated Perl package; no surprises here.

* source files match upstream:
   a1c287b5297ceef014910722f3ce8b3f  POE-Component-SimpleDBI-1.12.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(POE::Component::SimpleDBI) = 1.12
   perl(POE::Component::SimpleDBI::SubProcess) = 1.09
   perl-POE-Component-SimpleDBI = 1.12-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(DBI)
   perl(Error)
   perl(POE)
   perl(POE::Filter::Line)
   perl(POE::Filter::Reference)
   perl(POE::Session)
   perl(POE::Wheel::Run)
   perl(strict)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=2,  0 wallclock secs ( 0.10 cusr +  0.04 csys =  0.14 CPU)
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.

APPROVED

Comment 2 Chris Weyl 2006-09-03 05:14:52 UTC

+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-5)
+Close bug

Thanks for the review!