Bug 2045561

Summary: Cluster Autoscaler should use the same default Group value as Cluster API
Product: OpenShift Container Platform Reporter: Michael McCune <mimccune>
Component: Cloud ComputeAssignee: Michael McCune <mimccune>
Cloud Compute sub component: Cluster Autoscaler QA Contact: sunzhaohua <zhsun>
Status: CLOSED ERRATA Docs Contact:
Severity: low    
Priority: low CC: aos-bugs
Version: 4.10   
Target Milestone: ---   
Target Release: 4.10.0   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-10 16:42:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Michael McCune 2022-01-25 17:21:33 UTC
During the recent rebase for kubernetes 1.23, the default constant for the Group variable that contains the scalable resource (MachineSets) got reverted to a previous value. This reversion was an error and we should maintain the value from the upstream implementation to ensure that we do not break users by regressing without a warning.

Comment 4 sunzhaohua 2022-01-28 03:29:25 UTC
@Michael I checked in 4.11.0-0.nightly-2022-01-27-182501 and 4.10.0-0.nightly-2022-01-27-144113 the CAPI_GROUP is still "machine.openshift.io", am I missing something?

$ oc edit deploy cluster-autoscaler-default
        - cluster-autoscaler
        - name: CAPI_GROUP
          value: machine.openshift.io

Comment 5 Michael McCune 2022-01-28 20:06:48 UTC
@Zhaohua, no, that is correct. this change would be very difficult for us to test properly as we actually don't want to use the upstream label. but, we had modified the code in a way that might break some of our uses like hypershift (they use cluster-api more directly).

as long as we have not introduced regressions with this change, i would be happy with the results.

Comment 6 sunzhaohua 2022-01-29 03:39:42 UTC
Thanks Michael, move this to verified.

Comment 9 errata-xmlrpc 2022-03-10 16:42:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.