Bug 2045561 - Cluster Autoscaler should use the same default Group value as Cluster API
Summary: Cluster Autoscaler should use the same default Group value as Cluster API
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cloud Compute
Version: 4.10
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.10.0
Assignee: Michael McCune
QA Contact: sunzhaohua
Depends On:
TreeView+ depends on / blocked
Reported: 2022-01-25 17:21 UTC by Michael McCune
Modified: 2022-03-10 16:42 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Last Closed: 2022-03-10 16:42:23 UTC
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Github openshift kubernetes-autoscaler pull 220 0 None open Bug 2045561: revert defaultCAPIGroup constant 2022-01-25 17:22:26 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-10 16:42:39 UTC

Description Michael McCune 2022-01-25 17:21:33 UTC
During the recent rebase for kubernetes 1.23, the default constant for the Group variable that contains the scalable resource (MachineSets) got reverted to a previous value. This reversion was an error and we should maintain the value from the upstream implementation to ensure that we do not break users by regressing without a warning.

Comment 4 sunzhaohua 2022-01-28 03:29:25 UTC
@Michael I checked in 4.11.0-0.nightly-2022-01-27-182501 and 4.10.0-0.nightly-2022-01-27-144113 the CAPI_GROUP is still "machine.openshift.io", am I missing something?

$ oc edit deploy cluster-autoscaler-default
        - cluster-autoscaler
        - name: CAPI_GROUP
          value: machine.openshift.io

Comment 5 Michael McCune 2022-01-28 20:06:48 UTC
@Zhaohua, no, that is correct. this change would be very difficult for us to test properly as we actually don't want to use the upstream label. but, we had modified the code in a way that might break some of our uses like hypershift (they use cluster-api more directly).

as long as we have not introduced regressions with this change, i would be happy with the results.

Comment 6 sunzhaohua 2022-01-29 03:39:42 UTC
Thanks Michael, move this to verified.

Comment 9 errata-xmlrpc 2022-03-10 16:42:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.