Bug 2046024

Summary:	virsh domsetlaunchsecstate not report an error message when the input parameter is not enough
Product:	Red Hat Enterprise Linux 9	Reporter:	Luyao Huang <lhuang>
Component:	libvirt	Assignee:	Ján Tomko <jtomko>
libvirt sub component:	CLI & API	QA Contact:	Luyao Huang <lhuang>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	jdenemar, jtomko, lmen, virt-maint, xuzhang
Version:	9.0	Keywords:	Upstream
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	9.1
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-8.1.0-1.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-11-15 10:03:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:	8.1.0
Embargoed:

Description Luyao Huang 2022-01-26 08:11:53 UTC

Description of problem:
virsh domsetlaunchsecstate not report an error message when the input parameter is not enough 

Version-Release number of selected component (if applicable):
libvirt-daemon-8.0.0-1.module+el8.6.0+13888+55157bfb.x86_64

How reproducible:
100%

Steps to Reproduce:
1. only pass vm name when use domsetlaunchsecstate
# virsh domsetlaunchsecstate vm1

# echo $?
1

2.
3.

Actual results:
Libvirt doesn't set an error message when return

Expected results:
Report an error when the user didn't pass enough parameters

Additional info:

Comment 1 Ján Tomko 2022-01-26 15:56:47 UTC

Upstream patch:
https://listman.redhat.com/archives/libvir-list/2022-January/msg01196.html

Comment 2 Ján Tomko 2022-01-27 18:45:55 UTC

v2:
https://listman.redhat.com/archives/libvir-list/2022-January/msg01247.html

Comment 3 Ján Tomko 2022-01-31 14:51:19 UTC

Pushed upstream as:
commit d248e3dca83f1fc51599e02b827f35bc21fcaeb0
Author:     Ján Tomko <jtomko>
CommitDate: 2022-01-31 13:38:11 +0100

    virsh: domsetlaunchsecstate: report error if no options are passed
    
    We already exit if they are not present.
    
    Report an error, but do not mark them as required in case a future
    version of this command will want to accept a different set of
    parameters.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=2046024
    
    Signed-off-by: Ján Tomko <jtomko>
    Reviewed-by: Michal Privoznik <mprivozn>

git describe: v8.0.0-224-gd248e3dca8

Comment 6 Luyao Huang 2022-04-15 01:45:03 UTC

Verify this bug with libvirt-8.2.0-1.el9.x86_64:

# virsh domsetlaunchsecstate vm1
error: Both secret and the secret header are required

# echo $?
1

Comment 8 errata-xmlrpc 2022-11-15 10:03:03 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: libvirt security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8003