Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2046024

Summary: virsh domsetlaunchsecstate not report an error message when the input parameter is not enough
Product: Red Hat Enterprise Linux 9 Reporter: Luyao Huang <lhuang>
Component: libvirtAssignee: Ján Tomko <jtomko>
libvirt sub component: CLI & API QA Contact: Luyao Huang <lhuang>
Status: CLOSED ERRATA Docs Contact:
Severity: low    
Priority: low CC: jdenemar, jtomko, lmen, virt-maint, xuzhang
Version: 9.0Keywords: Upstream
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 9.1   
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-8.1.0-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-11-15 10:03:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version: 8.1.0
Embargoed:

Description Luyao Huang 2022-01-26 08:11:53 UTC
Description of problem:
virsh domsetlaunchsecstate not report an error message when the input parameter is not enough 

Version-Release number of selected component (if applicable):
libvirt-daemon-8.0.0-1.module+el8.6.0+13888+55157bfb.x86_64

How reproducible:
100%

Steps to Reproduce:
1. only pass vm name when use domsetlaunchsecstate
# virsh domsetlaunchsecstate vm1

# echo $?
1

2.
3.

Actual results:
Libvirt doesn't set an error message when return

Expected results:
Report an error when the user didn't pass enough parameters

Additional info:

Comment 3 Ján Tomko 2022-01-31 14:51:19 UTC
Pushed upstream as:
commit d248e3dca83f1fc51599e02b827f35bc21fcaeb0
Author:     Ján Tomko <jtomko>
CommitDate: 2022-01-31 13:38:11 +0100

    virsh: domsetlaunchsecstate: report error if no options are passed
    
    We already exit if they are not present.
    
    Report an error, but do not mark them as required in case a future
    version of this command will want to accept a different set of
    parameters.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=2046024
    
    Signed-off-by: Ján Tomko <jtomko>
    Reviewed-by: Michal Privoznik <mprivozn>

git describe: v8.0.0-224-gd248e3dca8

Comment 6 Luyao Huang 2022-04-15 01:45:03 UTC
Verify this bug with libvirt-8.2.0-1.el9.x86_64:

# virsh domsetlaunchsecstate vm1
error: Both secret and the secret header are required

# echo $?
1

Comment 8 errata-xmlrpc 2022-11-15 10:03:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: libvirt security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8003