Bug 2048158
| Summary: | Review Request: rust-helvum - GTK patchbay for pipewire | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-02-01 18:09:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2048157 | ||
| Bug Blocks: | |||
|
Description
Michel Lind
2022-01-29 19:45:28 UTC
note: not packaging the latest 0.3.3 as it requires a newer gtk4 (and that requires updatinng the entire gtk-rs) Taking this review. Initial review notes: Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - executable produced with correct binary subpackage - builds and installs There are a couple of issues, though: - meson_options.txt is captured as a doc file for some reason? For what purpose? - The primary build script is actually Meson and not Cargo, and some files are only installed through Meson. Please take a look at this and see if there's something to adjust here... huh yes, thanks. updated! same URLs We haven't yet made the switch to SPDX identifiers, so you need to manually fix up GPL-3.0-only to GPLv3. I trust you can do that on import. Otherwise, I think things look good now, so... PACKAGE APPROVED. Thanks! That could be a rust2rpm lack of mapping, I'll take a look at that too michel in fedora in specs on master [?] via 🌙 v5.4.3 ❯ fedpkg request-repo rust-helvum 2048158 https://pagure.io/releng/fedora-scm-requests/issue/41577 michel in fedora in specs on master [?] via 🌙 v5.4.3 ❯ fedpkg request-branch --repo rust-helvum --all-releases https://pagure.io/releng/fedora-scm-requests/issue/41578 https://pagure.io/releng/fedora-scm-requests/issue/41579 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-helvum FEDORA-2022-9b7fe450fe has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9b7fe450fe FEDORA-2022-be12c06331 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-be12c06331 FEDORA-2022-be12c06331 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-9b7fe450fe has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-9b7fe450fe \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9b7fe450fe See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-9b7fe450fe has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |