Bug 2048158 - Review Request: rust-helvum - GTK patchbay for pipewire
Summary: Review Request: rust-helvum - GTK patchbay for pipewire
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2048157
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-29 19:45 UTC by Michel Lind
Modified: 2022-02-03 02:08 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-02-01 18:09:50 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2022-01-29 19:45:28 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-helvum.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-helvum-0.3.1-1.fc35.src.rpm
Description: GTK patchbay for pipewire.
Fedora Account System Username: salimma

Comment 1 Michel Lind 2022-01-29 19:54:01 UTC
note: not packaging the latest 0.3.3 as it requires a newer gtk4 (and that requires updatinng the entire gtk-rs)

Comment 2 Neal Gompa 2022-01-29 20:08:12 UTC
Taking this review.

Comment 3 Neal Gompa 2022-01-29 20:14:05 UTC
Initial review notes:

Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- executable produced with correct binary subpackage
- builds and installs

There are a couple of issues, though:

- meson_options.txt is captured as a doc file for some reason? For what purpose?
- The primary build script is actually Meson and not Cargo, and some files are only installed through Meson.

Please take a look at this and see if there's something to adjust here...

Comment 4 Michel Lind 2022-01-29 20:17:15 UTC
huh yes, thanks.

Comment 5 Michel Lind 2022-01-30 20:48:00 UTC
updated! same URLs

Comment 6 Neal Gompa 2022-01-30 20:51:06 UTC
We haven't yet made the switch to SPDX identifiers, so you need to manually fix up GPL-3.0-only to GPLv3. I trust you can do that on import.

Otherwise, I think things look good now, so...

PACKAGE APPROVED.

Comment 7 Michel Lind 2022-01-30 20:53:29 UTC
Thanks! That could be a rust2rpm lack of mapping, I'll take a look at that too

Comment 8 Michel Lind 2022-01-30 23:07:22 UTC
michel in fedora in specs on  master [?] via 🌙 v5.4.3
❯ fedpkg request-repo rust-helvum 2048158
https://pagure.io/releng/fedora-scm-requests/issue/41577

michel in fedora in specs on  master [?] via 🌙 v5.4.3
❯ fedpkg request-branch --repo rust-helvum --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/41578
https://pagure.io/releng/fedora-scm-requests/issue/41579

Comment 9 Gwyn Ciesla 2022-01-31 18:27:19 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-helvum

Comment 10 Fedora Update System 2022-02-01 18:04:48 UTC
FEDORA-2022-9b7fe450fe has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9b7fe450fe

Comment 11 Fedora Update System 2022-02-01 18:06:04 UTC
FEDORA-2022-be12c06331 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-be12c06331

Comment 12 Fedora Update System 2022-02-01 18:09:50 UTC
FEDORA-2022-be12c06331 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-02-02 16:37:42 UTC
FEDORA-2022-9b7fe450fe has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-9b7fe450fe \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9b7fe450fe

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-02-03 02:08:29 UTC
FEDORA-2022-9b7fe450fe has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.