Bug 2048794
| Summary: | Review Request: netavark - OCI network stack | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lokesh Mandvekar <lsm5> |
| Component: | Package Review | Assignee: | Jindrich Novy <jnovy> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | igor.raits, package-review, travier |
| Target Milestone: | --- | Flags: | jnovy:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-02-13 01:14:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lokesh Mandvekar
2022-01-31 20:41:45 UTC
Jindrich, the %autorelease and %autochangelog macros are recognized by koji, so those should be ok. Upstream depends on 3 versions of nix so that's why you'll see them listed in Provides. Binary stripping doesn't work in rpmbuild, says empty debugsource, so I've disabled it for now as in aardvark-dns There is a typo in package description: --- etavark is a tool for configuring networking for Linux containers. Its features include: --- rpmlint also complains that description line size is too long: --- netavark.x86_64: E: description-line-too-long C to work with Podman but is also applicable for other OCI container management applications. netavark.x86_64: E: description-line-too-long C etavark is a tool for configuring networking for Linux containers. Its features include: netavark.x86_64: E: description-line-too-long C * Creation and management of required network interfaces, including MACVLAN networks netavark.x86_64: E: description-line-too-long C * All required firewall configuration to perform NAT and port forwarding as required for containers netavark.x86_64: E: description-line-too-long C * Support for iptables and firewalld at present, with support for nftables planned in a future release --- it also says: netavark.x86_64: E: useless-provides bundled(crate(nix)) Can you please take a look? > # Latest upstream rtnetlink frequently required > # sha2, zbus, zvariant are currently out of date What about to collaborate and get them updated instead? > %if 0%{?fedora} > BuildRequires: go-md2man > %else > BuildRequires: golang-github-cpuguy83-md2man > %endif Probably BuildRequires: /usr/bin/md2man would be easier? (In reply to Jindrich Novy from comment #2) > There is a typo in package description: > > --- > etavark is a tool for configuring networking for Linux containers. Its > features include: > --- > > rpmlint also complains that description line size is too long: > > --- > netavark.x86_64: E: description-line-too-long C to work with Podman but is > also applicable for other OCI container management applications. > netavark.x86_64: E: description-line-too-long C etavark is a tool for > configuring networking for Linux containers. Its features include: > netavark.x86_64: E: description-line-too-long C * Creation and management of > required network interfaces, including MACVLAN networks > netavark.x86_64: E: description-line-too-long C * All required firewall > configuration to perform NAT and port forwarding as required for containers > netavark.x86_64: E: description-line-too-long C * Support for iptables and > firewalld at present, with support for nftables planned in a future release > --- > > it also says: > netavark.x86_64: E: useless-provides bundled(crate(nix)) > > Can you please take a look? Thanks Jindrich, those have been fixed. PTAL. (In reply to Igor Raits from comment #3) > > # Latest upstream rtnetlink frequently required > > # sha2, zbus, zvariant are currently out of date > > What about to collaborate and get them updated instead? I would love to but things are gonna keep breaking on a weekly if not daily basis and I just can't find the time for that right now. If netavark is going to be anything like podman, there would likely be a new release every week. > > > %if 0%{?fedora} > > BuildRequires: go-md2man > > %else > > BuildRequires: golang-github-cpuguy83-md2man > > %endif > > Probably BuildRequires: /usr/bin/md2man would be easier? This is just a temporary thing so I could get c9s copr builds for people that wanna test right away. It will soon be removed. Spec URL: https://gitlab.com/lsm5/netavark/-/raw/main/netavark.spec SRPM URL: https://gitlab.com/lsm5/netavark/-/raw/main/SRPMS/netavark-1.0.0~rc1-1.fc36.src.rpm I think Igor's comment (thanks for it!) makes sense as the requirement is package independent and just pulls in what is really needed. Granting review+ as Lokesh will do this based on comment #4. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/netavark > I would love to but things are gonna keep breaking on a weekly if not daily basis and I just
> can't find the time for that right now. If netavark is going to be anything like podman,
> there would likely be a new release every week.
I still don't see this as an issue as long as we work together (we can give you access to the @rust-sig so you will get commit access to all rust-* packages).
FEDORA-2022-8fe17669a8 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8fe17669a8 FEDORA-2022-8fe17669a8 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-8fe17669a8 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8fe17669a8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-d0d128e8f0 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-d0d128e8f0` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d0d128e8f0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-d0d128e8f0 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-d0d128e8f0` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d0d128e8f0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-d0d128e8f0 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. *** Bug 2027417 has been marked as a duplicate of this bug. *** |