Bug 2048794 - Review Request: netavark - OCI network stack
Summary: Review Request: netavark - OCI network stack
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jindrich Novy
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2027417 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-31 20:41 UTC by Lokesh Mandvekar
Modified: 2022-03-23 14:15 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-02-13 01:14:35 UTC
Type: ---
Embargoed:
jnovy: fedora-review+


Attachments (Terms of Use)

Description Lokesh Mandvekar 2022-01-31 20:41:45 UTC
Spec URL: https://gitlab.com/lsm5/netavark/-/raw/main/netavark.spec
SRPM URL: https://gitlab.com/lsm5/netavark/-/raw/main/SRPMS/netavark-1.0.0~rc1-1.fc36.src.rpm

Description:
%{summary}

Netavark is a rust based network stack for containers.  It is being designed
to work with Podman but is also applicable for other OCI container management applications.

etavark is a tool for configuring networking for Linux containers. Its features include:
* Configuration of container networks via JSON configuration file
* Creation and management of required network interfaces, including MACVLAN networks
* All required firewall configuration to perform NAT and port forwarding as required for containers
* Support for iptables and firewalld at present, with support for nftables planned in a future release
* Support for rootless containers
* Support for IPv4 and IPv6
* Support for container DNS resolution via aardvark-dns.

Fedora Account System Username: lsm5


Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=82200653

Comment 1 Lokesh Mandvekar 2022-01-31 20:45:30 UTC
Jindrich, the %autorelease and %autochangelog macros are recognized by koji, so those should be ok.

Upstream depends on 3 versions of nix so that's why you'll see them listed in Provides.

Binary stripping doesn't work in rpmbuild, says empty debugsource, so I've disabled it for now as in aardvark-dns

Comment 2 Jindrich Novy 2022-02-01 10:07:39 UTC
There is a typo in package description:

---
etavark is a tool for configuring networking for Linux containers. Its features include:
---

rpmlint also complains that description line size is too long:

---
netavark.x86_64: E: description-line-too-long C to work with Podman but is also applicable for other OCI container management applications.
netavark.x86_64: E: description-line-too-long C etavark is a tool for configuring networking for Linux containers. Its features include:
netavark.x86_64: E: description-line-too-long C * Creation and management of required network interfaces, including MACVLAN networks
netavark.x86_64: E: description-line-too-long C * All required firewall configuration to perform NAT and port forwarding as required for containers
netavark.x86_64: E: description-line-too-long C * Support for iptables and firewalld at present, with support for nftables planned in a future release
---

it also says:
netavark.x86_64: E: useless-provides bundled(crate(nix))

Can you please take a look?

Comment 3 Igor Raits 2022-02-01 13:11:55 UTC
> # Latest upstream rtnetlink frequently required
> # sha2, zbus, zvariant are currently out of date

What about to collaborate and get them updated instead?

> %if 0%{?fedora}
> BuildRequires: go-md2man
> %else
> BuildRequires: golang-github-cpuguy83-md2man
> %endif

Probably BuildRequires: /usr/bin/md2man would be easier?

Comment 4 Lokesh Mandvekar 2022-02-01 14:28:40 UTC
(In reply to Jindrich Novy from comment #2)
> There is a typo in package description:
> 
> ---
> etavark is a tool for configuring networking for Linux containers. Its
> features include:
> ---
> 
> rpmlint also complains that description line size is too long:
> 
> ---
> netavark.x86_64: E: description-line-too-long C to work with Podman but is
> also applicable for other OCI container management applications.
> netavark.x86_64: E: description-line-too-long C etavark is a tool for
> configuring networking for Linux containers. Its features include:
> netavark.x86_64: E: description-line-too-long C * Creation and management of
> required network interfaces, including MACVLAN networks
> netavark.x86_64: E: description-line-too-long C * All required firewall
> configuration to perform NAT and port forwarding as required for containers
> netavark.x86_64: E: description-line-too-long C * Support for iptables and
> firewalld at present, with support for nftables planned in a future release
> ---
> 
> it also says:
> netavark.x86_64: E: useless-provides bundled(crate(nix))
> 
> Can you please take a look?

Thanks Jindrich, those have been fixed. PTAL.




(In reply to Igor Raits from comment #3)
> > # Latest upstream rtnetlink frequently required
> > # sha2, zbus, zvariant are currently out of date
> 
> What about to collaborate and get them updated instead?

I would love to but things are gonna keep breaking on a weekly if not daily basis and I just
can't find the time for that right now. If netavark is going to be anything like podman,
there would likely be a new release every week.

> 
> > %if 0%{?fedora}
> > BuildRequires: go-md2man
> > %else
> > BuildRequires: golang-github-cpuguy83-md2man
> > %endif
> 
> Probably BuildRequires: /usr/bin/md2man would be easier?

This is just a temporary thing so I could get c9s copr builds for people that wanna test right away.
It will soon be removed.

Comment 6 Jindrich Novy 2022-02-01 16:08:21 UTC
I think Igor's comment (thanks for it!) makes sense as the requirement is package independent and just pulls in what is really needed. Granting review+ as Lokesh will do this based on comment #4.

Comment 7 Gwyn Ciesla 2022-02-01 16:30:39 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/netavark

Comment 8 Igor Raits 2022-02-01 18:02:56 UTC
> I would love to but things are gonna keep breaking on a weekly if not daily basis and I just
> can't find the time for that right now. If netavark is going to be anything like podman,
> there would likely be a new release every week.

I still don't see this as an issue as long as we work together (we can give you access to the @rust-sig so you will get commit access to all rust-* packages).

Comment 9 Fedora Update System 2022-02-01 18:15:06 UTC
FEDORA-2022-8fe17669a8 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8fe17669a8

Comment 10 Fedora Update System 2022-02-02 16:37:59 UTC
FEDORA-2022-8fe17669a8 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-8fe17669a8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8fe17669a8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-02-03 01:34:23 UTC
FEDORA-2022-d0d128e8f0 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-d0d128e8f0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d0d128e8f0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-02-05 02:11:36 UTC
FEDORA-2022-d0d128e8f0 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-d0d128e8f0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d0d128e8f0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-02-13 01:14:35 UTC
FEDORA-2022-d0d128e8f0 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Lokesh Mandvekar 2022-03-23 14:15:35 UTC
*** Bug 2027417 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.