Bug 2051047
| Summary: | Review Request: koko - An Image gallery application | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Justin Zobel <justin.zobel> |
| Component: | Package Review | Assignee: | Onuralp Sezer <thunderbirdtr> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, thunderbirdtr |
| Target Milestone: | --- | Flags: | thunderbirdtr:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-05-11 01:19:28 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Justin Zobel
2022-02-06 01:24:57 UTC
Spec URL: https://pagure.io/koko_rpm/raw/master/f/koko.spec SRPM URL: https://pagure.io/koko_rpm/raw/master/f/koko-22.02-1.fc35.src.rpm Updated and fixed a few items in fedora-review Please note fedora-review will likely error on this package with `Sources used to build the package match the upstream source, as provided in the spec URL.` as the upstream GeoNames files change regularly. The only other fedora-review item is a duplicate build ID file, which I have no control over: File listed twice: /usr/lib/.build-id/3d/8c1e4d371421dd268811332f88dff40fd447d1 Licenses *appear* to match but someone more license orientated will need to confirm.
We can change add those files into our src.fpo website so it won't give error, build-id is fine.
Licenses are looks good to me
Also could you modify file section for consistency of variable usage. you use "koko" and "%{name}" so please replace
%{_kf5_qmldir}/org/kde/koko/* <-- can be change
%{_kf5_datadir}/koko <--- can be change
If app name decide to change their name or something It will be consistent, minimal to work.
Rest of them looks good. I approve the package but please do the changes in final spec file. Thank you
Package approved.
Requsted repo + branches, will add fixes in before build https://pagure.io/releng/fedora-scm-requests/issue/44076 https://pagure.io/releng/fedora-scm-requests/issue/44077 https://pagure.io/releng/fedora-scm-requests/issue/44078 https://pagure.io/releng/fedora-scm-requests/issue/44079 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/koko FEDORA-2022-7335530cf6 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7335530cf6 FEDORA-2022-8ffbf53460 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8ffbf53460 FEDORA-2022-7335530cf6 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-7335530cf6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-7335530cf6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-8ffbf53460 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-8ffbf53460 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8ffbf53460 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-7335530cf6 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-8ffbf53460 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |