Bug 2051047 - Review Request: koko - An Image gallery application
Summary: Review Request: koko - An Image gallery application
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Onuralp Sezer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-02-06 01:24 UTC by Justin Zobel
Modified: 2022-05-11 01:25 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-11 01:19:28 UTC
Type: Bug
Embargoed:
thunderbirdtr: fedora-review+


Attachments (Terms of Use)

Description Justin Zobel 2022-02-06 01:24:57 UTC
Spec URL: https://pagure.io/koko_rpm/raw/master/f/koko.spec
SRPM URL: https://pagure.io/koko_rpm/raw/master/f/koko-21.12-1.fc35.src.rpm 

Description: An Image gallery application
Fedora Account System Username: justinz

Pagure URL: https://pagure.io/koko_rpm

Comment 1 Justin Zobel 2022-02-26 05:44:55 UTC
Spec URL: https://pagure.io/koko_rpm/raw/master/f/koko.spec
SRPM URL: https://pagure.io/koko_rpm/raw/master/f/koko-22.02-1.fc35.src.rpm 

Updated and fixed a few items in fedora-review

Comment 2 Justin Zobel 2022-03-11 01:14:00 UTC
Please note fedora-review will likely error on this package with `Sources used to build the package match the upstream source, as provided in the spec URL.` as the upstream GeoNames files change regularly.

The only other fedora-review item is a duplicate build ID file, which I have no control over: File listed twice: /usr/lib/.build-id/3d/8c1e4d371421dd268811332f88dff40fd447d1

Licenses *appear* to match but someone more license orientated will need to confirm.

Comment 3 Onuralp Sezer 2022-04-29 13:03:09 UTC
We can change add those files into our src.fpo website so it won't give error,  build-id is fine.

Licenses are looks good to me

Also could you modify file section for consistency of variable usage. you use "koko" and "%{name}" so please replace 

%{_kf5_qmldir}/org/kde/koko/* <--   can be change
%{_kf5_datadir}/koko <---  can be change

If app name decide to change their name or something It will be consistent, minimal to work. 


Rest of them looks good. I approve the package but please do the changes in final spec file. Thank you

Package approved.

Comment 5 Gwyn Ciesla 2022-05-02 15:02:00 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/koko

Comment 6 Fedora Update System 2022-05-03 02:51:50 UTC
FEDORA-2022-7335530cf6 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7335530cf6

Comment 7 Fedora Update System 2022-05-03 02:51:51 UTC
FEDORA-2022-8ffbf53460 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8ffbf53460

Comment 8 Fedora Update System 2022-05-03 13:33:20 UTC
FEDORA-2022-7335530cf6 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-7335530cf6 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-7335530cf6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2022-05-03 15:28:43 UTC
FEDORA-2022-8ffbf53460 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-8ffbf53460 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8ffbf53460

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-05-11 01:19:28 UTC
FEDORA-2022-7335530cf6 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-05-11 01:25:32 UTC
FEDORA-2022-8ffbf53460 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.