Bug 2051069
| Summary: | Review Request: khealthcertificate - Handling of digital vaccination, test and recovery certificates. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Justin Zobel <justin.zobel> |
| Component: | Package Review | Assignee: | Mark E. Fuller <mark.e.fuller> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mark.e.fuller, package-review, pemensik |
| Target Milestone: | --- | Flags: | mark.e.fuller:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-02-27 04:08:33 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2051073 | ||
|
Description
Justin Zobel
2022-02-06 06:05:42 UTC
Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Some additional things: -the devel package should have "Requires: %{name}%{?_isa} = %{version}-%{release}" -are tests being run? I see no %check section in the spec file, but a "tests" directory in the source code: please add this section and run tests if applicable Requested changes made. Spec URL: https://pagure.io/khealthcertificate_rpm/raw/master/f/khealthcertificate.spec SRPM URL: https://pagure.io/khealthcertificate_rpm/raw/master/f/khealthcertificate-22.02-1.fc35.src.rpm Sorry about the delay in getting back to this. As in https://bugzilla.redhat.com/show_bug.cgi?id=2051055, > %{_kf5_libdir}/*.so.* Please add soversion number here to avoid accidental bumps: %{_kf5_libdir}/*.so.1* (or appropriate number if not 1) I think that's everything Not a problem. Updated as per request. Spec URL: https://pagure.io/khealthcertificate_rpm/raw/master/f/khealthcertificate.spec SRPM URL: https://pagure.io/khealthcertificate_rpm/raw/master/f/khealthcertificate-22.02-1.fc35.src.rpm Looks good - I approve (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/khealthcertificate FEDORA-2022-b808a39e4b has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b808a39e4b FEDORA-2022-fa30369522 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fa30369522 FEDORA-2022-fa30369522 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-fa30369522 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-fa30369522 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-b808a39e4b has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-b808a39e4b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b808a39e4b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-b808a39e4b has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-fa30369522 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. |