Bug 2051069 - Review Request: khealthcertificate - Handling of digital vaccination, test and recovery certificates.
Summary: Review Request: khealthcertificate - Handling of digital vaccination, test an...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mark E. Fuller
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2051073
TreeView+ depends on / blocked
 
Reported: 2022-02-06 06:05 UTC by Justin Zobel
Modified: 2022-03-11 14:14 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-02-27 04:08:33 UTC
Type: Bug
Embargoed:
mark.e.fuller: fedora-review+


Attachments (Terms of Use)

Description Justin Zobel 2022-02-06 06:05:42 UTC
Spec URL: https://pagure.io/khealthcertificate_rpm/raw/master/f/khealthcertificate.spec
SRPM URL: https://pagure.io/khealthcertificate_rpm/raw/master/f/khealthcertificate-21.12-1.fc35.src.rpm

Description: Handling of digital vaccination, test and recovery certificates.
Fedora Account System Username: justinz

Pagure URL: https://pagure.io/khealthcertificate_rpm

Comment 1 Mark E. Fuller 2022-02-07 10:37:32 UTC
Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/



Some additional things:

-the devel package should have "Requires: %{name}%{?_isa} = %{version}-%{release}"

-are tests being run? I see no %check section in the spec file, but a "tests" directory in the source code: please add this section and run tests if applicable

Comment 3 Mark E. Fuller 2022-02-15 09:14:52 UTC
Sorry about the delay in getting back to this.

As in https://bugzilla.redhat.com/show_bug.cgi?id=2051055,

> %{_kf5_libdir}/*.so.*

Please add soversion number here to avoid accidental bumps:
%{_kf5_libdir}/*.so.1*
(or appropriate number if not 1)

I think that's everything

Comment 5 Mark E. Fuller 2022-02-16 13:58:11 UTC
Looks good - I approve

Comment 6 Gwyn Ciesla 2022-02-17 15:06:09 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/khealthcertificate

Comment 7 Fedora Update System 2022-02-21 23:52:08 UTC
FEDORA-2022-b808a39e4b has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b808a39e4b

Comment 8 Fedora Update System 2022-02-21 23:52:58 UTC
FEDORA-2022-fa30369522 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fa30369522

Comment 9 Fedora Update System 2022-02-22 03:01:20 UTC
FEDORA-2022-fa30369522 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-fa30369522 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-fa30369522

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-02-22 03:13:14 UTC
FEDORA-2022-b808a39e4b has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-b808a39e4b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b808a39e4b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-02-27 04:08:33 UTC
FEDORA-2022-b808a39e4b has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2022-03-11 14:14:57 UTC
FEDORA-2022-fa30369522 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.