Bug 2051212
| Summary: | Review Request: rust-wasmtime - High-level API to expose the Wasmtime runtime | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Aleksei Bavshin <alebastr89> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | alebastr89, package-review |
| Target Milestone: | --- | Flags: | alebastr89:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-03-10 22:32:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2051022, 2051157, 2051191 | ||
| Bug Blocks: | 2051222, 2051227 | ||
|
Description
Fabio Valentini
2022-02-06 15:52:14 UTC
Successful COPR builds of all packages for all available architectures: https://copr.fedorainfracloud.org/coprs/decathorpe/wasmtime/monitor/ - The `vtune` optional feature depends on `wasmtime-jit/vtune` which you've already removed and is broken. Please, update the metadata patch to remove it (it's fine to do that before import).
% rg --glob Cargo.toml vtune
2051212-rust-wasmtime/rpms-unpacked/rust-wasmtime-devel-0.33.0-1.fc37.noarch.rpm/usr/share/cargo/registry/wasmtime-0.33.0/Cargo.toml
126:vtune = ["wasmtime-jit/vtune"]
- Deprecation warning is already fixed in v0.34.0.
LGTM
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines
Package APPROVED.
Thanks for the review! I have a .rust2rpm.conf file for dropping the uffd and vtune features, but that's not shipped with the SRPM. I'll make sure to import that file. https://pagure.io/releng/fedora-scm-requests/issue/42897 https://pagure.io/releng/fedora-scm-requests/issue/42898 https://pagure.io/releng/fedora-scm-requests/issue/42899 https://pagure.io/releng/fedora-scm-requests/issue/42900 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wasmtime Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1932198 Will be submitted to bodhi and built for stable branches shortly. |