Bug 2051212 - Review Request: rust-wasmtime - High-level API to expose the Wasmtime runtime
Summary: Review Request: rust-wasmtime - High-level API to expose the Wasmtime runtime
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Aleksei Bavshin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2051022 2051157 2051191
Blocks: 2051222 2051227
TreeView+ depends on / blocked
 
Reported: 2022-02-06 15:52 UTC by Fabio Valentini
Modified: 2022-03-10 22:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-03-10 22:32:56 UTC
Type: ---
Embargoed:
alebastr89: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2022-02-06 15:52:14 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-wasmtime.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-wasmtime-0.33.0-1.fc35.src.rpm

Description:
High-level API to expose the Wasmtime runtime.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2022-02-06 17:25:38 UTC
Successful COPR builds of all packages for all available architectures:
https://copr.fedorainfracloud.org/coprs/decathorpe/wasmtime/monitor/

Comment 2 Aleksei Bavshin 2022-03-10 03:49:18 UTC
 - The `vtune` optional feature depends on `wasmtime-jit/vtune` which you've already removed and is broken. Please, update the metadata patch to remove it (it's fine to do that before import).
    % rg --glob Cargo.toml vtune
    2051212-rust-wasmtime/rpms-unpacked/rust-wasmtime-devel-0.33.0-1.fc37.noarch.rpm/usr/share/cargo/registry/wasmtime-0.33.0/Cargo.toml
    126:vtune = ["wasmtime-jit/vtune"]
 - Deprecation warning is already fixed in v0.34.0.

LGTM

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fabio Valentini 2022-03-10 13:30:55 UTC
Thanks for the review!
I have a .rust2rpm.conf file for dropping the uffd and vtune features, but that's not shipped with the SRPM. I'll make sure to import that file.

https://pagure.io/releng/fedora-scm-requests/issue/42897
https://pagure.io/releng/fedora-scm-requests/issue/42898
https://pagure.io/releng/fedora-scm-requests/issue/42899
https://pagure.io/releng/fedora-scm-requests/issue/42900

Comment 4 Gwyn Ciesla 2022-03-10 14:48:41 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wasmtime

Comment 5 Fabio Valentini 2022-03-10 22:32:56 UTC
Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1932198

Will be submitted to bodhi and built for stable branches shortly.


Note You need to log in before you can comment on or make changes to this bug.