Bug 205127

Summary:	Review Request: ekg - A client compatible with Gadu-Gadu
Product:	[Fedora] Fedora	Reporter:	Dominik 'Rathann' Mierzejewski <dominik>
Component:	Package Review	Assignee:	Michał Bentkowski <mr.ecik>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	gajownik
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-09-07 13:32:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 200436, 205136

Description Dominik 'Rathann' Mierzejewski 2006-09-04 12:46:06 UTC

Spec URL: http://rpm.greysector.net/extras/ekg.spec
SRPM URL: http://rpm.greysector.net/extras/ekg-1.7-0.1.rc2.src.rpm
Description:
EKG ("Eksperymentalny Klient Gadu-Gadu") is an open source gadu-gadu
client for UNIX systems. Gadu-Gadu is an instant messaging program,
very popular in Poland.

NOTE: this package contains the libgadu library, which can be used by other Instant Messaging software.

Comment 1 Michał Bentkowski 2006-09-04 17:15:03 UTC

Official review:

MUST items:

 * rpmlint output:
W: libgadu no-documentation
 * package is named good.
 * spec file is named good.
 * package almost meets Packaging Guidelines (it'll be defined later)
 * License field matches actual license
 * license is NOT included in %doc in libgadu
 * spec file is legible
 * md5sums are matching (b4ea482130e163af1456699e2e6983d9)
 * package successfully builds on x86_64
 * build dependencies are properly listed in BuildRequires
 * no locales
 * package contains shared library files and package calls ldconfig
in %post and %postun
 * package owns its directories
 * no duplicates in %files
 * correct %defattr lines
 * proper %clean section
 * no gui

THINGS you have to do:

 * add %{?dist} tag to Release
 * add license file to libgadu package (COPYING is in lib directory)
 * remove python BR, because python-devel will add it

If you fix what I mentioned above, I'll approve it.

Comment 2 Dominik 'Rathann' Mierzejewski 2006-09-06 17:45:41 UTC

http://rpm.greysector.net/extras/ekg.spec
http://rpm.greysector.net/extras/ekg-1.7-0.2.rc2.src.rpm

- add dist tag
- add license files to libgadu and ekg
- remove reduntant python BR
- fix parallel make build

Comment 3 Michał Bentkowski 2006-09-06 20:56:39 UTC

Approved.

Comment 4 Dominik 'Rathann' Mierzejewski 2006-09-07 13:32:33 UTC

Imported and built for devel. FC-5 branch requested.