Bug 2051421
| Summary: | Review Request: golang-github-grpc-ecosystem-gateway-2 - GRPC to JSON proxy generator following the gRPC HTTP spec | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Alessandro Locati <me> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-02-13 20:08:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabio Alessandro Locati
2022-02-07 08:32:03 UTC
- Fix the line encoding of these files: golang-github-grpc-ecosystem-gateway-2.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2/examples/internal/proto/examplepb/standalone_echo_service.yaml golang-github-grpc-ecosystem-gateway-2.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2/examples/internal/proto/examplepb/unannotated_echo_service.yaml golang-github-grpc-ecosystem-gateway-2-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2-devel/examples/internal/proto/examplepb/standalone_echo_service.yaml golang-github-grpc-ecosystem-gateway-2-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2-devel/examples/internal/proto/examplepb/unannotated_echo_service.yaml golang-github-grpc-ecosystem-gateway-2.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2/examples/internal/proto/examplepb/standalone_echo_service.yaml golang-github-grpc-ecosystem-gateway-2.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2/examples/internal/proto/examplepb/unannotated_echo_service.yaml golang-github-grpc-ecosystem-gateway-2-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2-devel/examples/internal/proto/examplepb/standalone_echo_service.yaml golang-github-grpc-ecosystem-gateway-2-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2-devel/examples/internal/proto/examplepb/unannotated_echo_service.yaml - Remove .gitgnore files everywhere and other hidden files (except .goipath) - You'll get errors om 32 bits arches: https://koji.fedoraproject.org/koji/taskinfo?taskID=82497680 Disable the test: %gocheck -d protoc-gen-openapiv2/internal/genopenapi - Consider using rpmautospec Thanks Eclipseo :-) I've improved the SPEC file (same location), rebuilt the srpm (same location), and scratch-built: https://koji.fedoraproject.org/koji/taskinfo?taskID=82509297 LGTM, package approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-grpc-ecosystem-gateway-2 |