2051421 – Review Request: golang-github-grpc-ecosystem-gateway-2 - GRPC to JSON proxy generator following the gRPC HTTP spec

Bug 2051421 - Review Request: golang-github-grpc-ecosystem-gateway-2 - GRPC to JSON proxy generator following the gRPC HTTP spec

Summary: Review Request: golang-github-grpc-ecosystem-gateway-2 - GRPC to JSON proxy g...

Keywords:
Status:	CLOSED CURRENTRELEASE
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	All
OS:	Linux
Priority:	medium
Severity:	medium
Target Milestone:	---
Assignee:	Robert-André Mauchin 🐧
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2022-02-07 08:32 UTC by Fabio Alessandro Locati
Modified:	2022-02-13 20:08 UTC (History)
CC List:	2 users (show)
Fixed In Version:
Clone Of:
Environment:
Last Closed:	2022-02-13 20:08:27 UTC
Type:	---
Embargoed:
Dependent Products:
Flags:	eclipseo: fedora-review+

Attachments	(Terms of Use)

Description Fabio Alessandro Locati 2022-02-07 08:32:03 UTC

Spec URL: https://fale.fedorapeople.org/golang-github-grpc-ecosystem-gateway-2/golang-github-grpc-ecosystem-gateway-2.spec
SRPM URL: https://fale.fedorapeople.org/golang-github-grpc-ecosystem-gateway-2/golang-github-grpc-ecosystem-gateway-2-2.7.3-1.fc35.src.rpm
Description: GRPC to JSON proxy generator following the gRPC HTTP spec
Fedora Account System Username: fale

Comment 1 Robert-André Mauchin 🐧 2022-02-07 11:52:38 UTC

 - Fix the line encoding of these files:

golang-github-grpc-ecosystem-gateway-2.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2/examples/internal/proto/examplepb/standalone_echo_service.yaml
golang-github-grpc-ecosystem-gateway-2.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2/examples/internal/proto/examplepb/unannotated_echo_service.yaml
golang-github-grpc-ecosystem-gateway-2-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2-devel/examples/internal/proto/examplepb/standalone_echo_service.yaml
golang-github-grpc-ecosystem-gateway-2-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2-devel/examples/internal/proto/examplepb/unannotated_echo_service.yaml
golang-github-grpc-ecosystem-gateway-2.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2/examples/internal/proto/examplepb/standalone_echo_service.yaml
golang-github-grpc-ecosystem-gateway-2.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2/examples/internal/proto/examplepb/unannotated_echo_service.yaml
golang-github-grpc-ecosystem-gateway-2-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2-devel/examples/internal/proto/examplepb/standalone_echo_service.yaml
golang-github-grpc-ecosystem-gateway-2-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-grpc-ecosystem-gateway-2-devel/examples/internal/proto/examplepb/unannotated_echo_service.yaml

 - Remove .gitgnore files everywhere and other hidden files (except .goipath)

 - You'll get errors om 32 bits arches: https://koji.fedoraproject.org/koji/taskinfo?taskID=82497680
Disable the test: %gocheck -d protoc-gen-openapiv2/internal/genopenapi

 - Consider using rpmautospec

Comment 2 Fabio Alessandro Locati 2022-02-07 16:57:38 UTC

Thanks Eclipseo :-)

I've improved the SPEC file (same location), rebuilt the srpm (same location), and scratch-built: https://koji.fedoraproject.org/koji/taskinfo?taskID=82509297

Comment 3 Robert-André Mauchin 🐧 2022-02-07 18:52:18 UTC

LGTM, package approved.

Comment 4 Gwyn Ciesla 2022-02-08 15:13:06 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-grpc-ecosystem-gateway-2

Note You need to log in before you can comment on or make changes to this bug.