Bug 2052402

Summary:	Review Request: rust-greetd_ipc - Implementation of the greetd IPC protocol
Product:	[Fedora] Fedora	Reporter:	Aleksei Bavshin <alebastr89>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rust-greetd_ipc-0.8.0-1.fc37	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-02-10 05:00:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2052407

Description Aleksei Bavshin 2022-02-09 08:13:05 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/alebastr/greetd/fedora-rawhide-x86_64/03005766-rust-greetd_ipc/rust-greetd_ipc.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/greetd/fedora-rawhide-x86_64/03005766-rust-greetd_ipc/rust-greetd_ipc-0.8.0-1.fc36.src.rpm
Description:
Implementation of the greetd IPC protocol

Fedora Account System Username: alebastr

Review notes: rust2rpm -a
AFAIK, it's not a problem if the GPL license file is missing in the archive. I'll ping upstream anyways.

Comment 1 Neal Gompa 2022-02-09 09:39:35 UTC

Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

Additional note: %autorelease isn't terribly effective if you're putting version-release in manual changelog entries. You probably want to rework your changelog entry to not include the release value (since that would be dynamic) or just switch to %autochangelog. The %autorelease goop at the top of the spec should be dropped on import too.

Comment 2 Gwyn Ciesla 2022-02-09 15:06:29 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-greetd_ipc