Bug 2052402 - Review Request: rust-greetd_ipc - Implementation of the greetd IPC protocol
Summary: Review Request: rust-greetd_ipc - Implementation of the greetd IPC protocol
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2052407
TreeView+ depends on / blocked
 
Reported: 2022-02-09 08:13 UTC by Aleksei Bavshin
Modified: 2022-02-10 05:00 UTC (History)
2 users (show)

Fixed In Version: rust-greetd_ipc-0.8.0-1.fc37
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-02-10 05:00:56 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Aleksei Bavshin 2022-02-09 08:13:05 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/alebastr/greetd/fedora-rawhide-x86_64/03005766-rust-greetd_ipc/rust-greetd_ipc.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/greetd/fedora-rawhide-x86_64/03005766-rust-greetd_ipc/rust-greetd_ipc-0.8.0-1.fc36.src.rpm
Description:
Implementation of the greetd IPC protocol

Fedora Account System Username: alebastr

Review notes: rust2rpm -a
AFAIK, it's not a problem if the GPL license file is missing in the archive. I'll ping upstream anyways.

Comment 1 Neal Gompa 2022-02-09 09:39:35 UTC
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

Additional note: %autorelease isn't terribly effective if you're putting version-release in manual changelog entries. You probably want to rework your changelog entry to not include the release value (since that would be dynamic) or just switch to %autochangelog. The %autorelease goop at the top of the spec should be dropped on import too.

Comment 2 Gwyn Ciesla 2022-02-09 15:06:29 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-greetd_ipc


Note You need to log in before you can comment on or make changes to this bug.