Bug 2053963

> %global common_description %{expand:
> Xkcd style password generator library and cli tool.}
> (...)
> Summary:        Xkcd style password generator library and cli tool

Should be `xkcd` instead of `Xkcd` as described in https://xkcd.com/about/

> %global godocs          README.md wordlists/eff_short_wordlist_2_0.txt\\\
>                        wordlists/eff_large_wordlist.txt\\\
>                        wordlists/de_wordlist.txt
> %doc README.md wordlists/eff_short_wordlist_2_0.txt
> %doc wordlists/eff_large_wordlist.txt wordlists/de_wordlist.txt

The wordlist are included in the code, I don't think they should go as doc.

> for cmd in _generator; do
>   %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
> done

The cmd in _generator is used to generate the generated.go file in xkcdpwgen, I don't think it makes sense to ship it in Fedora

> BuildRequires:  golang(golang.org/x/tools/imports)
> (...)
> %generate_buildrequires
> %go_generate_buildrequires

As the package only depends on golang(golang.org/x/tools/imports) and in golang(github.com/stretchr/testify/assert) for tests, maybe you can just use one method.

On top of all that, consider using rpmautospec for easier future maintenance.

I changed this, but I forgot to upload and comment -_-. Sorry for the delay.

SPEC: https://fale.fedorapeople.org/golang-github-martinhoefling-goxkcdpwgen/golang-github-martinhoefling-goxkcdpwgen.spec
SRPM: https://fale.fedorapeople.org/golang-github-martinhoefling-goxkcdpwgen/golang-github-martinhoefling-goxkcdpwgen-0-1.20220222git7dc3d10.fc35.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=84298863

Thanks a lot Mikel :-)

Thanks applying proposed changes.

go2rpm package, fedora-review is correct:

- The specfile is sane
- License is correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes (no tests available)
- The latest version is packaged
- The package complies with the Packaging Guidelines

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-martinhoefling-goxkcdpwgen

FEDORA-2022-0702344b40 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0702344b40

FEDORA-2022-956bb75251 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-956bb75251

FEDORA-2022-0702344b40 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-0702344b40 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0702344b40

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-956bb75251 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-956bb75251 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-956bb75251

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-956bb75251 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-0702344b40 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.