As gopass is a known app, it makes sense to rename golang-github-gopasspw-gopass.spec to gopass.spec, as done with doctl for example. You'll need to rename the BZ title accordingly.

- Define "%global goname gopass" as in https://src.fedoraproject.org/rpms/doctl/blob/rawhide/f/doctl.spec#_15

>for cmd in helpers/postrel pkg/pwgen/pwrules helpers/man helpers/changelog helpers/release; do
>  %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
>done

These are not required for gopass usage, can be removed.

Hi Mikel,

Looking doctl, I notice that the "master" package is also named that way. Should I close this request and create a new one with the right name as well?

Thanks a lot,
Fale

> Should I close this request and create a new one with the right name as well?

You can just rename the BZ title and upload a new spec/srpm with the new name for review.

SPEC: https://fale.fedorapeople.org/gopass/gopass.spec
SRPM: https://fale.fedorapeople.org/gopass/gopass-1.13.1-1.fc35.src.rpm
Copr: https://copr.fedorainfracloud.org/coprs/fale/gopass/build/3725247/

Thanks a lot!!

As mentioned, the auxiliary commands are not required for gopass (not packaged in the official binary release for example), so unless you've a good reason they can be dropped. You should remove this parts of the spec:

> %build
> %gobuild -o %{gobuilddir}/bin/gopass %{goipath}
> for cmd in helpers/postrel pkg/pwgen/pwrules helpers/man helpers/changelog helpers/release; do
>   %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
> done

(...)

> install -m 0755 -vd                     %{buildroot}%{_bindir}
> install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/

(...)

> %files
> %license LICENSE
> %doc docs CONTRIBUTING.md GOVERNANCE.md README.md ARCHITECTURE.md CHANGELOG.md
> %{_bindir}/*

Sorry for that, I made a little bit of mess on my filesystem while renaming files and folders.

SPEC: https://fale.fedorapeople.org/gopass/gopass.spec
SRPM: https://fale.fedorapeople.org/gopass/gopass-1.13.1-1.fc35.src.rpm
COPR: https://copr.fedorainfracloud.org/coprs/fale/gopass/build/3730796/

Thanks a lot Mikel for your suggestions and patience :-)

Sorry, my previous comment was not correct, as you still need gopass binary of course. Anyhow, you did the correct thing, sorry again about that.

I just realized that check section is being ignored, you should use `%bcond_without check`

I did some changes and upload a new spec here: https://mikel.olasagasti.info/tmp/fedora/gopass.spec

- Enable tests
- Add BuildRequires for tests
- Add Requires
- Generate bash/fish/zsh completions. For some reason bash ones seem not to work
- Test TestFind fails, I added a skip for it
- Other tests, internal/backend/storage/fs/link_test.go pkg/appdir/appdir_xdg_test.go pkg/pwgen/validate_test.go pkg/termio/identity_test.go, fail with the following error, but I was not able to trace it correctly:

> code in directory /usr/share/gocode/src/gotest.tools/assert expects import "gotest.tools/v3/assert"

Check these changes and adapt them to your spec.

No problem and a huge thankyou for your SPEC file which allowed me to greatly improve the tests and SH completion :-).

SPEC: https://fale.fedorapeople.org/gopass/gopass.spec
SRPM: https://fale.fedorapeople.org/gopass/gopass-1.13.1-1.fc35.src.rpm
COPR: https://copr.fedorainfracloud.org/coprs/fale/gopass/build/3734378/

> Requires:       git
> Requires:       gnupg
> BuildRequires:  git-core
> BuildRequires:  gnupg2

I would use the same Requires as in BuildRequires.

> #rm internal/backend/storage/fs/link_test.go pkg/appdir/appdir_xdg_test.go pkg/pwgen/validate_test.go pkg/termio/identity_test.go

Remove this leftover.

After these changes I think package can be approved.

Hi!

SPEC: https://fale.fedorapeople.org/gopass/gopass.spec
SRPM: https://fale.fedorapeople.org/gopass/gopass-1.13.1-1.fc35.src.rpm
COPR: https://copr.fedorainfracloud.org/coprs/fale/gopass/build/3736098/


Thanks a lot :-)

go2rpm package with some extras, fedora-review is correct:

- The specfile is sane
- License is correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes
- The latest version is packaged
- The package complies with the Packaging Guidelines

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/gopass

FEDORA-2022-4506cf983b has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4506cf983b

FEDORA-2022-9036145a7b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9036145a7b

FEDORA-2022-4506cf983b has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4506cf983b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4506cf983b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-9036145a7b has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-9036145a7b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9036145a7b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-4506cf983b has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.