Bug 2053964
| Summary: | Review Request: golang-github-skip2-qrcode - QR Code encoder | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Alessandro Locati <me> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mikel, package-review |
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-03-25 23:15:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2053969 | ||
|
Description
Fabio Alessandro Locati
2022-02-13 16:22:32 UTC
> %global common_description %{expand: > :sparkles: QR Code encoder (Go).} > (...) > Summary: :sparkles: QR Code encoder (Go) Remove the `:sparkles:` emoji. > # Generated by go2rpm 1.6.0 > %bcond_with check The tests can be fixed by applying the patch in https://github.com/skip2/go-qrcode/pull/53 You can use %bcond_without check (...) Source0: %{gosource} Patch0001: https://patch-diff.githubusercontent.com/raw/skip2/go-qrcode/pull/53.patch (...) %goprep %patch0001 -p1 > %generate_buildrequires > %go_generate_buildrequires Currently doesn't have any dep, you can remove this. Thanks a lot Mikel! Spec URL: https://fale.fedorapeople.org/golang-github-skip2-qrcode/golang-github-skip2-qrcode.spec SRPM URL: https://fale.fedorapeople.org/golang-github-skip2-qrcode/golang-github-skip2-qrcode-0-0.1.20220222gitda1b656.fc35.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=83186813 go2rpm package, fedora-review is correct: - The specfile is sane. - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes - The latest version is packaged - The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - Add package to release-monitoring.org - Add package to Koschei. - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. Thanks! (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-skip2-qrcode FEDORA-2022-dcbe6e7665 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-dcbe6e7665 FEDORA-2022-d50943202e has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d50943202e FEDORA-2022-dcbe6e7665 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-dcbe6e7665 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-dcbe6e7665 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-d50943202e has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-d50943202e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d50943202e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-dcbe6e7665 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-d50943202e has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |