Bug 2053966

Summary: Review Request: golang-github-caspr-io-yamlpath - Golang YAML Path implementation
Product: [Fedora] Fedora Reporter: Fabio Alessandro Locati <me>
Component: Package ReviewAssignee: Mikel Olasagasti Uranga <mikel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mikel, package-review
Target Milestone: ---Flags: mikel: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-25 23:15:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2053969    

Comment 1 Mikel Olasagasti Uranga 2022-03-09 21:09:32 UTC
Package is correct, but is missing license file. The file was added after the 0.0.1 release.

You can for example patch the package to include the commit that adds the LICENSE file or you can package the latest git version so you've it included.

If you decide to go with the later, you can use the following command:

go2rpm -r -c 502e8d113a9bbfd7c4980af2e60a655e21fca0b6 -v 0.0.1 https://github.com/caspr-io/yamlpath

Comment 3 Mikel Olasagasti Uranga 2022-03-14 14:08:49 UTC
go2rpm package, fedora-review is correct:

- The specfile is sane.
- License is now correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes
- The latest version is packaged
- The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei.
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket.

Thanks!

Comment 4 Tomas Hrcka 2022-03-14 19:25:33 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-caspr-io-yamlpath

Comment 5 Fedora Update System 2022-03-16 23:20:31 UTC
FEDORA-2022-18d98e0bb8 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-18d98e0bb8

Comment 6 Fedora Update System 2022-03-17 15:23:04 UTC
FEDORA-2022-5c99b030c8 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-5c99b030c8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-5c99b030c8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2022-03-17 17:11:37 UTC
FEDORA-2022-18d98e0bb8 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-18d98e0bb8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-18d98e0bb8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2022-03-25 23:15:29 UTC
FEDORA-2022-5c99b030c8 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2022-03-26 15:24:03 UTC
FEDORA-2022-18d98e0bb8 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.